-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thcrap-steam-proton-wrapper: init at 0-unstable-2024-04-03 #301845
thcrap-steam-proton-wrapper: init at 0-unstable-2024-04-03 #301845
Conversation
Result of 1 package built:
|
Also change the PR title format to |
Binary appears to work correctly to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some nits, and adjust the PR title please
8e0c692 and 93efa69...99e296c are breaking Commit conventions For 8e0c692
The last 4 commits: 93efa69...99e296c can be squashed into one and be reworded to Also reword 93efa69 to Edit: Ideally you could squash all commits (except 8e0c692) into 14a035d and reword 14a035d to Edit 2: It would also be nice if 8e0c692 is the first commit and 14a035d is second one |
99e296c
to
64ae837
Compare
Okay, rebased and squashed commits, and reworded the commit about the version of the package and adding myself as maintainer. |
64ae837
to
03f2229
Compare
03f2229
to
0becc15
Compare
d940e92
to
084a73f
Compare
@ashuramaruzxc You'll want to reword |
084a73f
to
134db91
Compare
Sorry, my bad, used commit message from the zsh history, noticed it right immediately, fixed... |
Adding yourself to the maintainers file needs to be a separate commit |
134db91
to
b0fbe66
Compare
Successfully created backport PR for |
Description of changes
Add package with a wrapper script for running Touhou games under steam proton with:
thcrap patch (English localization, QOL and etc),
thprac (Practice tool),
vsync patch.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.