thcrap-steam-proton-wrapper: init at 0-unstable-2024-04-03

[ashuramaruzxc]

Description of changes

Add package with a wrapper script for running Touhou games under steam proton with:
thcrap patch (English localization, QOL and etc),
thprac (Practice tool),
vsync patch.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

1 package built:
thcrap-steam-proton-wrapper

• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[msanft]

Result of nixpkgs-review pr 301845 run on x86_64-linux 1

1 package built:

• thcrap-steam-proton-wrapper

[msanft]

Also change the PR title format to thcrap-steam-proton-wrapper: init at 0-unstable-2024-04-03 please @ashuramaruzxc

[msanft]

Binary appears to work correctly to me

[msanft]

Only some nits, and adjust the PR title please

[DontEatOreo]

8e0c692ce697dc588effaef6e7b517c64b19529a and 93efa69ec58fd4332bbfa66871ef61c8d686d331...99e296c41b4a5819636bdd9c20b14224dcfbb3ff are breaking Commit conventions

For 8e0c692ce697dc588effaef6e7b517c64b19529a

• When adding yourself as maintainer in the same pull request, make a separate commit with the message maintainers: add <handle>.

For 93efa69ec58fd4332bbfa66871ef61c8d686d331...99e296c41b4a5819636bdd9c20b14224dcfbb3ff

• If you have commits pkg-name: oh, forgot to insert whitespace: squash commits in this case. Use git rebase -i.

The last 4 commits: 93efa69ec58fd4332bbfa66871ef61c8d686d331...99e296c41b4a5819636bdd9c20b14224dcfbb3ff can be squashed into one and be reworded to thcrap-steam-proton-wrapper: apply suggestions from code review

Also reword 93efa69ec58fd4332bbfa66871ef61c8d686d331 to thcrap-steam-proton-wrapper: add long description

Edit: Ideally you could squash all commits (except 8e0c692ce697dc588effaef6e7b517c64b19529a) into 14a035d16cfbe53712c78f46880b9ff86691028a and reword 14a035d16cfbe53712c78f46880b9ff86691028a to thcrap-steam-proton-wrapper: init at 0-unstable-2024-04-03

Edit 2: It would also be nice if 8e0c692ce697dc588effaef6e7b517c64b19529a is the first commit and 14a035d16cfbe53712c78f46880b9ff86691028a is second one

[ashuramaruzxc]

Okay, rebased and squashed commits, and reworded the commit about the version of the package and adding myself as maintainer.
@DontEatOreo

[msanft]

@ashuramaruzxc You'll want to reword format: use nixfmt-rfc-style instead of alejandra into thcrap-steam-proton-wrapper: init at 0-unstable-2024-04-03

[ashuramaruzxc]

@ashuramaruzxc You'll want to reword format: use nixfmt-rfc-style instead of alejandra into thcrap-steam-proton-wrapper: init at 0-unstable-2024-04-03

Sorry, my bad, used commit message from the zsh history, noticed it right immediately, fixed...

[DontEatOreo]

Adding yourself to the maintainers file needs to be a separate commit

[github-actions]

Successfully created backport PR for release-23.11:

• [Backport release-23.11] thcrap-steam-proton-wrapper: init at 0-unstable-2024-04-03 #303302