Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thc-secure-delete: init at 3.1.1 #302269

Merged
merged 1 commit into from
Jun 25, 2024
Merged

thc-secure-delete: init at 3.1.1 #302269

merged 1 commit into from
Jun 25, 2024

Conversation

Tochiaha
Copy link
Contributor

@Tochiaha Tochiaha commented Apr 7, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 7, 2024
@Aleksanaa
Copy link
Member

The latest change was already 5 years ago. Do you really want it (for a good reason)? After reading the readme I think shred (installed on NixOS by default) should cover its use cases.

@Tochiaha
Copy link
Contributor Author

Tochiaha commented Apr 7, 2024

The latest change was already 5 years ago. Do you really want it (for a good reason)? After reading the readme I think shred (installed on NixOS by default) should cover its use cases.

does shred really cover all its use cases, i know srm is already packaged but what about sdmem sfill and sswap they apply different techniques though compared to shred.

@Tochiaha Tochiaha changed the title Thc secure delete Thc secure delete: init at 3.1.1 Apr 7, 2024
@drupol drupol changed the title Thc secure delete: init at 3.1.1 thc-secure-delete: init at 3.1.1 Apr 7, 2024
drupol
drupol requested changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is broken on Darwin...

drupol
drupol requested changes Apr 8, 2024
View reviewed changes
pkgs/by-name/th/thc-secure-delete/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/th/thc-secure-delete/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/th/thc-secure-delete/package.nix Outdated Show resolved Hide resolved
drupol
drupol requested changes Apr 8, 2024
View reviewed changes
pkgs/by-name/th/thc-secure-delete/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/th/thc-secure-delete/package.nix Outdated Show resolved Hide resolved
@MikaelFangel
Copy link
Contributor

Supersedes: #268796

@Tochiaha Tochiaha requested a review from drupol April 9, 2024 02:13
drupol
drupol approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

drupol
drupol previously requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a build issue on Darwin, can you check and eventually fix it?

@Tochiaha
Copy link
Contributor Author

Tochiaha commented Apr 12, 2024 •
edited
Loading

There's a build issue on Darwin, can you check and eventually fix it?

@drupol Had to check alternative, is the recent file changes acceptable?

@Tochiaha Tochiaha requested a review from drupol April 12, 2024 01:11
@Tochiaha Tochiaha force-pushed the thc-secure-delete branch 2 times, most recently from e4fbfb5 to f98aeca Compare April 16, 2024 23:33
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Apr 17, 2024
@Tochiaha Tochiaha requested a review from drupol April 21, 2024 13:33
@Tochiaha Tochiaha force-pushed the thc-secure-delete branch 2 times, most recently from ca55d0f to 98becbb Compare April 21, 2024 14:32
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4143

@wegank wegank merged commit b099e37 into NixOS:master Jun 25, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@reckenrode reckenrode reckenrode left review comments

@2xsaiko 2xsaiko 2xsaiko approved these changes

@viraptor viraptor viraptor left review comments

@wegank wegank wegank approved these changes

@eclairevoyant eclairevoyant eclairevoyant approved these changes

@drupol drupol Awaiting requested review from drupol

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.