kcl: init at 0.8.5 #302285
Closed
kcl: init at 0.8.5 #302285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2024
msanft
suggested changes
Apr 7, 2024
There was a problem hiding this comment.
Please adjust commit & PR title according to the conventions
| pname = "kcl"; | ||
| version = "0.8.4"; | ||
|
|
||
| src = if stdenv.isDarwin && stdenv.isAarch64 then fetchurl { |
There was a problem hiding this comment.
When having this many sources, it might be advisable to create a sources.json and then read the URL endings and hashes from there. For reference, see e.g. the tabnine package.
| sha256 = "9a86ef943ca7df1a21801fb91be8092d04835d1d555c146da89c1149d33a4c42"; | ||
| } else throw "Unsupported platform"; | ||
|
|
||
| unpackPhase = "tar -xzf $src"; |
There was a problem hiding this comment.
Suggested change
| unpackPhase = "tar -xzf $src"; |
Unpacking TAR files should happen by default: https://nixos.org/manual/nixpkgs/stable/#tar-files
Comment on lines
+23
to
+26
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp kcl $out/bin/ | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| installPhase = '' | |
| mkdir -p $out/bin | |
| cp kcl $out/bin/ | |
| ''; | |
| installPhase = '' | |
| runHook preInstall | |
| mkdir -p $out/bin | |
| cp kcl $out/bin/ | |
| runHook postInstall | |
| ''; |
Peefy
changed the title
|
Since the source is available on github, why not build from source directly? nix-init almost generates a working package by default Generated package
{ lib
, buildGoModule
, fetchFromGitHub
}:
buildGoModule rec {
pname = "kcl";
version = "0.8.5";
src = fetchFromGitHub {
owner = "kcl-lang";
repo = "cli";
rev = "v${version}";
hash = "sha256-ZjEMgQukhBGY3LWqsGmLj3lKfLtNNaQugQs0cSLMb80=";
};
vendorHash = "sha256-jmqKMB85HxAlwH7FVjHrLCZQYuAJrguRfzIz1yMypjw=";
ldflags = [
"-X=kcl-lang.io/cli/pkg/version.version=${version}"
];
subPackages = [ "cmd/kcl" ];
meta = with lib; {
description = "The KCL Command Line Interface (CLI";
homepage = "https://github.com/kcl-lang/cli";
license = licenses.asl20;
maintainers = with maintainers; [ ];
mainProgram = "cli";
};
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.