Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osm2world: init at unstable-2024-02-25 #302303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eliandoran
Copy link
Contributor

@eliandoran eliandoran commented Apr 7, 2024

Description of changes

Official website: https://osm2world.org/

OSM2World is a converter that creates three-dimensional models of the world from OpenStreetMap data. It can be used as a stand-alone tool, on a server or as a library in Java programs.

image

Notes:

org.apache.commons.configuration.ConfigurationException: Unable to load the configuration from the URL

This exception appears in logs at startup and as a message box when opening an OSM file, however this does not seem to affect the functionality of the app.

In any case, it seems this error can be suppressed as follows:

touch test.properties
osm2world --gui --config test.properties

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/os/osm2world/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/os/osm2world/package.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg eval

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a maven expert but doesn't look to wrong to me

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 9, 2024
};
in mavenJdk17.buildMavenPackage {
pname = "osm2world";
version = "unstable-2024-02-25";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "unstable-2024-02-25";
version = "0-unstable-2024-02-25";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants