Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaultwarden.webvault: 2024.3.0 -> 2024.3.1 #302389

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Apr 7, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 7, 2024
@dotlambda
Copy link
Member

@ofborg test vaultwarden

@dotlambda
Copy link
Member

The NixOS test fails for me with

server # [   43.696682] vaultwarden[811]: [2024-04-08 19:37:20.956][request][INFO] GET /api/config
server # [   43.699462] vaultwarden[811]: [2024-04-08 19:37:20.956][response][INFO] (config) GET /api/config => 200 OK
server # [   53.816437] test-runner[927]: Traceback (most recent call last):
server # [   53.822889] test-runner[927]:   File "/run/current-system/sw/bin/test-runner", line 18, in <module>
server # [   53.832460] test-runner[927]:     wait.until(EC.title_contains("Create account"))
server # [   53.840907] test-runner[927]:   File "/nix/store/bk2kan47zhbf6zzka099wc0s2dp66car-python3-3.11.8-env/lib/python3.11/site-packages/selenium/webdriver/support/wait.py", line 105, in until
server # [   53.850198] test-runner[927]:     raise TimeoutException(message, screen, stacktrace)
server # [   53.852376] test-runner[927]: selenium.common.exceptions.TimeoutException: Message:

@SuperSandro2000
Copy link
Member Author

When directly visiting the registration page, the page title is not updated anymore. I am not to much bothered with that and just changed the test.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Apr 8, 2024
@dotlambda
Copy link
Member

@ofborg test vaultwarden

@dotlambda dotlambda merged commit 0dca190 into NixOS:master Apr 9, 2024
23 of 24 checks passed
@SuperSandro2000 SuperSandro2000 deleted the vaultwarden-webvault branch April 9, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants