Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nemu: init at 3.3.1 #302407

Merged
merged 1 commit into from
Apr 22, 2024
Merged

nemu: init at 3.3.1 #302407

merged 1 commit into from
Apr 22, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Apr 7, 2024

Description of changes

Things done

Add NEMU, an ncurses-based TUI for QEMU.

Closes #302371

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 7, 2024
@arthsmn
Copy link
Member

arthsmn commented Apr 7, 2024

Also don't use rec { foo = bar; }, use (finalAttrs: { foo = finalAttrs.bar; }) instead.

@arthsmn
Copy link
Member

arthsmn commented Apr 8, 2024

The diff looks good, but why is it failing to build?

Copy link
Member

@arthsmn arthsmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Built on x86_64-linux.

@arthsmn
Copy link
Member

arthsmn commented Apr 8, 2024

@ofborg build nemu

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 9, 2024
@msanft
Copy link
Contributor Author

msanft commented Apr 9, 2024

The diff looks good, but why is it failing to build?

I'm not exactly sure. We saw the same failure here: #302488

Also, the Darwin build fails. I do not have a MacOS nor a BSD machine at hand to prove that the builds work for these platforms, and I'd rather not test it with ofborg in my development-build cycle. Do you have strong opinions against marking this broken for Darwin and BSD for the time being?

@msanft
Copy link
Contributor Author

msanft commented Apr 9, 2024

@ofborg eval

@msanft
Copy link
Contributor Author

msanft commented Apr 9, 2024

@ofborg build

@katexochen
Copy link
Contributor

katexochen commented Apr 9, 2024

./results/nemu/bin/ntty
+ socat=/usr/bin/socat
+ socat_args='/tmp/ntty--help pty,raw,link=/tmp/stty--help,echo=0'
+ picocom=/usr/bin/picocom
+ start-stop-daemon -Sb -mp /tmp/ntty--help.pid -x /usr/bin/socat -- /tmp/ntty--help pty,raw,link=/tmp/stty--help,echo=0
./results/nemu/bin/ntty: line 14: start-stop-daemon: command not found

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild labels Apr 9, 2024
@arthsmn
Copy link
Member

arthsmn commented Apr 9, 2024

The diff looks good, but why is it failing to build?

I'm not exactly sure. We saw the same failure here: #302488

Also, the Darwin build fails. I do not have a MacOS nor a BSD machine at hand to prove that the builds work for these platforms, and I'd rather not test it with ofborg in my development-build cycle. Do you have strong opinions against marking this broken for Darwin and BSD for the time being?

No, for me it's fine.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 9, 2024
@msanft
Copy link
Contributor Author

msanft commented Apr 10, 2024

@katexochen the issue you pointed out should be fixed now.

@katexochen katexochen merged commit 80368c5 into NixOS:master Apr 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: nemu
4 participants