Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/lazygit: init #302559

Merged
merged 1 commit into from
Apr 11, 2024
Merged

nixos/lazygit: init #302559

merged 1 commit into from
Apr 11, 2024

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Apr 8, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 8, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 8, 2024
@drupol
Copy link
Contributor

drupol commented Apr 8, 2024

Please, correct me if I'm wrong, but is it something we need in a NixOS module?
AFAIK, lazygit is not a service, so what's the point of having it in a module?

@linsui
Copy link
Contributor Author

linsui commented Apr 8, 2024

It's not a service so I put it in programs instead of services, right? We put it in a module to config it easily.

@drupol
Copy link
Contributor

drupol commented Apr 8, 2024

Ho my bad ! Sorry.

nixos/modules/programs/lazygit.nix Outdated Show resolved Hide resolved
nixos/modules/programs/lazygit.nix Outdated Show resolved Hide resolved
nixos/modules/programs/lazygit.nix Outdated Show resolved Hide resolved
nixos/modules/programs/lazygit.nix Show resolved Hide resolved
Update nixos/modules/programs/lazygit.nix

Co-authored-by: Aleksana <[email protected]>

Update nixos/modules/programs/lazygit.nix

Co-authored-by: Aleksana <[email protected]>
@drupol drupol merged commit 9034140 into NixOS:master Apr 11, 2024
21 checks passed
@linsui linsui deleted the lazygit branch April 12, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants