Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: add johnrtitor #302641

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 8, 2024

Description of changes

Adding myself to the maintainers list + maintainers for the lightningcss package

Things done

  • nix-instantiate --eval maintainers/scripts/check-maintainers-sorted.nix
  • nix-build lib/tests/maintainers.nix

@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented Apr 8, 2024

I have the backing of existing maintainer @toastal. Having an extra pair of eyes over the package updates should alleviate the update and maintaining process.
Furthermore, I am happy to oblige if further requirements need to be met to get accepted as a maintainer.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Apr 8, 2024
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@LeSuisse LeSuisse merged commit 5e1945f into NixOS:master Apr 8, 2024
26 checks passed
@JohnRTitor JohnRTitor deleted the maintainers-johnrtitor branch April 9, 2024 02:01
Copy link
Contributor

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-23.11
git worktree add -d .worktree/backport-302641-to-release-23.11 origin/release-23.11
cd .worktree/backport-302641-to-release-23.11
git switch --create backport-302641-to-release-23.11
git cherry-pick -x c5dc9a0758fee085743e775c84cc912b86c3e6ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants