Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux/common-config: enable RT1308 sound support module #302651

Closed

Conversation

workflow
Copy link
Contributor

@workflow workflow commented Apr 8, 2024

This module is required for working internal speakers on some versions of the Dell XPS 9700, possibly other laptops.

Upstreaming it removes the need for kernel rebuilds for these laptop users.

See #130882

Review ping: @Mic92 @tobiasBora

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This module is required for working internal speakers on **some** versions of the Dell XPS 9700, possibly
other laptops.

Upstreaming it removes the need for kernel rebuilds for these laptop
users.

See NixOS#130882
@Tungsten842
Copy link
Member

Tungsten842 commented Apr 8, 2024

This is already enabled in the default kernel config:

❯ cat $(nix build nixpkgs\#linux.configfile --print-out-paths) | grep SND_SOC_RT1308
CONFIG_SND_SOC_RT1308=m
CONFIG_SND_SOC_RT1308_SDW=m

❯ cat $(nix build nixpkgs\#linux_6_8.configfile --print-out-paths) | grep SND_SOC_RT1308
CONFIG_SND_SOC_RT1308=m
CONFIG_SND_SOC_RT1308_SDW=m

❯ cat $(nix build nixpkgs\#linux_6_6.configfile --print-out-paths) | grep SND_SOC_RT1308
CONFIG_SND_SOC_RT1308=m
CONFIG_SND_SOC_RT1308_SDW=m

❯ cat $(nix build nixpkgs\#linux_6_1.configfile --print-out-paths) | grep SND_SOC_RT1308
CONFIG_SND_SOC_RT1308=m
CONFIG_SND_SOC_RT1308_SDW=m

❯ cat $(nix build nixpkgs\#linux_5_15.configfile --print-out-paths) | grep SND_SOC_RT1308
CONFIG_SND_SOC_RT1308=m
CONFIG_SND_SOC_RT1308_SDW=m

@workflow
Copy link
Contributor Author

workflow commented Apr 8, 2024

Indeed, thank you, I must've been smoking something funky when I grepped for it.

@workflow workflow closed this Apr 8, 2024
@workflow workflow deleted the linux-common-config-enable-rt1308 branch April 8, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants