pyright: repackage using buildNpmPackage #302680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalekseev
commented
Apr 8, 2024
kalekseev
force-pushed
the
pyright
branch
2 times, most recently
from
2fbcaae
to
c933d49
Compare
|
Please fix merge conflict. |
superherointj
added
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
|
Result of 7 packages built:
|
superherointj
approved these changes
Apr 18, 2024
jonathan-conder
added a commit
to jonathan-conder/git-hooks.nix
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Repackages nodePackages.pyright to be built using buildNpmPackage as per the suggestion in #229475
Things done
Moved pyright to pkgs/by-name/py/pyright and removed it from node-packages.json.
Had to include package.json and package-lock.json to include
globandjsonc-parserbuild deps.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.