-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cuda-modules: rewrite setup hooks #302694
base: master
Are you sure you want to change the base?
cuda-modules: rewrite setup hooks #302694
Conversation
516dbd1
to
89e03ed
Compare
89e03ed
to
949e77e
Compare
@SomeoneSerge of some interest -- we're not in the global scope in the body of these setup hooks, I believe. I was running into errors when trying to use the associative arrays |
ff997bd
to
0d2e942
Compare
0d2e942
to
d0efe91
Compare
markForCudatoolkitRootHook = | ||
mkRenamed "markForCudatoolkitRootHook" "cudaPackages.markForCudatoolkitRoot" | ||
final.markForCudatoolkitRoot; # Added 2024-04-19 | ||
setupCudaHook = mkRenamed "setupCudaHook" "cudaPackages.setupCuda" final.setupCuda; # Added 2024-04-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember a discussion about this, and I agree there's little point in having the suffix, and it's ok not to have it... I don't know why bother renaming old stuff, but no strong opinions here on my part
Important
To-do:
Description of changes
markForCudatoolkitRoot
andsetupCuda
to make use of new logging utility and do general cleanupThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.