Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fragments: 2.1.1 -> 3.0.0 #303867

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fragments: 2.1.1 -> 3.0.0 #303867

merged 1 commit into from
Apr 25, 2024

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Apr 13, 2024

Description of changes

https://blogs.gnome.org/haeckerfelix/2024/04/07/fragments-3-0/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@linsui linsui requested a review from amaxine April 13, 2024 17:14
@JohnRTitor
Copy link
Contributor

JohnRTitor commented Apr 13, 2024

@ofborg build fragment

Also you might want to rebase the branch since eval is failing

@linsui
Copy link
Contributor Author

linsui commented Apr 13, 2024

Since this MR targets to the gnome-46 branch, I can't rebase it to master. No idea why the eval failed.

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 303867 run on x86_64-linux 1

1 package built:
  • fragments

@linsui linsui changed the title fragment: 2.1.1 -> 3.0.0 fragments: 2.1.1 -> 3.0.0 Apr 13, 2024
@linsui linsui force-pushed the fragments branch 3 times, most recently from 45115a2 to c6dd45b Compare April 13, 2024 18:28
@amaxine
Copy link
Contributor

amaxine commented Apr 13, 2024

@linsui to minimise the additional burden on the Gnome 46 branch and updates, could you please rebase this PR against master and keep it as a draft for now? There's already a few PRs doing the same thing for other gnome-adjacent software that needs gtk/libadwaita updates, and it's probably going to be lower burden for you as we will likely end up doing at least another rebase before we merge.

@linsui linsui marked this pull request as ready for review April 23, 2024 06:49
@linsui
Copy link
Contributor Author

linsui commented Apr 25, 2024

@amaxine This PR has been rebased onto staging-next. :)

@amaxine amaxine merged commit 749cfbe into NixOS:staging-next Apr 25, 2024
25 checks passed
@linsui linsui deleted the fragments branch April 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants