Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aphorme: init at 0.1.19 #304603

Merged
merged 2 commits into from
Apr 22, 2024
Merged

aphorme: init at 0.1.19 #304603

merged 2 commits into from
Apr 22, 2024

Conversation

AnyTimeTraveler
Copy link
Contributor

@AnyTimeTraveler AnyTimeTraveler commented Apr 16, 2024

Description of changes

Add the small and fast program launcher called aphorme

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Apr 16, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 16, 2024
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (and builds on my machine). One thing though: To speed up future time-to-review, consider adding a testVersion test. aphorme --version appears to contain the version :)

@AnyTimeTraveler
Copy link
Contributor Author

Lgtm (and builds on my machine). One thing though: To speed up future time-to-review, consider adding a testVersion test. aphorme --version appears to contain the version :)

Done :)

Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for this! (Might use this myself, seems useful 🙂)

@tomodachi94 tomodachi94 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 17, 2024
@Aleksanaa
Copy link
Member

Could you explain why you used your fork instead of the original one?

@AnyTimeTraveler
Copy link
Contributor Author

Could you explain why you used your fork instead of the original one?

The original creator changed the app version in the Cargo.toml to 0.1.19 and then pushed that change without rebuilding the corresponding Cargo.lock. Nix-build complained about the dirty Cargo.lock and refused to build.
The release I made to my fork only adds one commit, which updates the Cargo.lock.

@AnyTimeTraveler
Copy link
Contributor Author

I have been talking with the author and the next release is planned to be switched to the official repo, but there is no timeframe for when the next release will happen.

I will keep maintaining the Nix package either way, as they are not involved with Nix.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 18, 2024
@AnyTimeTraveler
Copy link
Contributor Author

Good news, everyone :)
I talked to the original author and the Cargo.lock has been pushed.
I just updated the buildscript to point to the original repo.

pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for this!

@tomodachi94 tomodachi94 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 20, 2024
pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Apr 21, 2024
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Apr 21, 2024
@wegank wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Apr 22, 2024
pkgs/by-name/ap/aphorme/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ap/aphorme/package.nix Show resolved Hide resolved
@eclairevoyant eclairevoyant merged commit 06fa7d1 into NixOS:master Apr 22, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants