-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aphorme: init at 0.1.19 #304603
aphorme: init at 0.1.19 #304603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm (and builds on my machine). One thing though: To speed up future time-to-review, consider adding a testVersion
test. aphorme --version
appears to contain the version :)
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for this! (Might use this myself, seems useful 🙂)
Could you explain why you used your fork instead of the original one? |
The original creator changed the app version in the |
I have been talking with the author and the next release is planned to be switched to the official repo, but there is no timeframe for when the next release will happen. I will keep maintaining the Nix package either way, as they are not involved with Nix. |
Good news, everyone :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for this!
Description of changes
Add the small and fast program launcher called aphorme
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.