Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] buildMozillaMach: fix version mismatch in llvmPackages #304740

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Apr 17, 2024

llvmPackagesBuildBuild0 had a wrong version (with FF >= 125)
That also caused lots of warnings and consequently exceeding log limits:
https://hydra.nixos.org/build/256471785

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

llvmPackagesBuildBuild0 had a wrong version (with FF >= 125)
That also caused lots of warnings and consequently exceeding log limits:
https://hydra.nixos.org/build/256471785
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Apr 17, 2024
@vcunat vcunat requested a review from mweinelt as a code owner April 17, 2024 07:49
@vcunat
Copy link
Member Author

vcunat commented Apr 17, 2024

I'm not sure if it's worth deduplicating the condition like I did.

@mweinelt
Copy link
Member

Not really worth optimizing at this point.

@vcunat vcunat changed the title buildMozillaMach: fix version mismatch in llvmPackages [23.11] buildMozillaMach: fix version mismatch in llvmPackages Apr 17, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 17, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 17, 2024
@vcunat
Copy link
Member Author

vcunat commented Apr 17, 2024

Only 28 MiB logs now for me (Hydra bailed at 60).

@mweinelt
Copy link
Member

That sounds pretty normal. Thanks!

@mweinelt mweinelt merged commit e402c3e into NixOS:release-23.11 Apr 17, 2024
26 checks passed
@vcunat vcunat deleted the p/firefox-23.11 branch April 17, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants