Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vencord: 1.7.4 -> 1.7.8 #305032

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

Scrumplex
Copy link
Member

Description of changes

Closes #305030

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Sefa Eyeoglu <[email protected]>
Signed-off-by: Sefa Eyeoglu <[email protected]>
@ofborg ofborg bot requested review from FlafyDev, fwam and NotAShelf April 18, 2024 11:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 18, 2024
Copy link
Member

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 305032 run on x86_64-linux 1

4 packages built:
  • vencord
  • vencord-web-extension
  • vesktop
  • webcord-vencord

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 18, 2024
@yosoof3
Copy link

yosoof3 commented Apr 19, 2024

could someone please merge this?

@Aleksanaa Aleksanaa merged commit 016df4b into NixOS:master Apr 19, 2024
29 checks passed
@NotAShelf
Copy link
Member

should this be backported?

@JohnRTitor
Copy link
Contributor

I don't see a reason for not backporting. It's parent Discord is almost always backported to latest stable release.

However this particular PR can't be automatically backported by the bot. One needs to manually cherry pick all the previous commits, including the file rename commit. Feel free to pick the job.

@Scrumplex
Copy link
Member Author

See #305542

@Scrumplex Scrumplex deleted the pkgs/vencord/update-2024-04 branch April 20, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: vencord 1.7.4 → 1.7.8
6 participants