Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] Electron updates #305271

Merged

Conversation

yayayayaka
Copy link
Member

Manual backport of #304890

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yayayayaka yayayayaka added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 19, 2024
@ofborg ofborg bot requested a review from yu-re-ka April 19, 2024 09:54
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Apr 19, 2024
Copy link
Contributor

@yu-re-ka yu-re-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would merge if someone confirms that all the variants still build

@yayayayaka yayayayaka force-pushed the backport-304890-to-release-23.11 branch from f3f944c to 90a6224 Compare April 19, 2024 10:39
@ofborg ofborg bot requested a review from yu-re-ka April 19, 2024 11:39
@yayayayaka
Copy link
Member Author

Result of nixpkgs-review pr 305271 run on x86_64-linux 1

2 packages failed to build:
  • authy
  • sharedown
46 packages built:
  • bilibili
  • bitwarden
  • camunda-modeler
  • drawio
  • drawio-headless
  • electron (electron_27)
  • electron_27-bin
  • electron_28
  • electron_28-bin
  • freetube
  • headset
  • heroic
  • heroic-unwrapped
  • itch
  • jitsi-meet-electron
  • logseq
  • mattermost-desktop
  • micropad
  • nix-tour
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • pocket-casts
  • podman-desktop
  • pritunl-client
  • python310Packages.mkdocs-drawio-exporter
  • python310Packages.mkdocs-drawio-exporter.dist
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • redisinsight
  • revolt-desktop
  • standardnotes
  • stretchly
  • super-productivity
  • teams-for-linux
  • terra-station
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • webcord
  • webcord-vencord
  • webtorrent_desktop

@yu-re-ka
Copy link
Contributor

yu-re-ka commented Apr 19, 2024 via email

@yayayayaka
Copy link
Member Author

There was no new electron_29 release at the time of preparing #304890.

@yu-re-ka yu-re-ka merged commit 0ca25f1 into NixOS:release-23.11 Apr 20, 2024
22 checks passed
@yayayayaka yayayayaka deleted the backport-304890-to-release-23.11 branch April 20, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants