Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.davidanson.vscode-markdownlint: 0.54.0 -> 0.55.0 #305303

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

datafoo
Copy link
Contributor

@datafoo datafoo commented Apr 19, 2024

(cherry picked from commit 6c3221a)

Manual backport following the failed automatic one (#305044 (comment)).

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@superherointj
Copy link
Contributor

CI is complaining about the cherry-pick. Try to remove the reference of a cherry-pick and make the changes cleanly and call it a back-port adaptation (instead of cherry-pick).

@datafoo datafoo force-pushed the backport-305044-to-release-23.11 branch from f9138f3 to 13835dc Compare April 22, 2024 06:54
@superherointj
Copy link
Contributor

superherointj commented Apr 24, 2024

Can you squash commits and rebase? (I hope rebase may solve eval.)

@wegank
Copy link
Member

wegank commented Apr 27, 2024

@ofborg eval

@wegank wegank merged commit 4ba625d into NixOS:release-23.11 Apr 27, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants