Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.ocrmypdf: 16.1.2 -> 16.2.0 #305616

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

dotlambda
Copy link
Member

Should I patch OCRmyPDF to use pillow-heif rather than adding pi-heif as a package?

Description of changes

Diff: ocrmypdf/OCRmyPDF@v16.1.2...v16.2.0

Changelog: https://github.com/ocrmypdf/OCRmyPDF/blob/v16.2.0/docs/release_notes.rst

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt
Copy link
Member

mweinelt commented Apr 20, 2024

Should I patch OCRmyPDF to use pillow-heif rather than adding pi-heif as a package?

Ugh … they don't like the GPL 2.0 library that wheels are distributed under, so they fork with a new name. Yes, please.

@dotlambda dotlambda merged commit 3443d8c into NixOS:master Apr 23, 2024
24 checks passed
@dotlambda dotlambda deleted the python3Packages.ocrmypdf branch April 23, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants