Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/release-small: fix eval #305623

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Apr 20, 2024

Provide nixpkgs.release-checks, which has been extracted out of the
tarball job into a dedicated one.

#304730 (comment)

$ nix-instantiate nixos/release-small.nix -A nixpkgs.release-checks
/nix/store/39h1qab3116p5mz351yq3w2qqfbll6xl-nixpkgs-release-checks.drv

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Provide nixpkgs.release-checks, which has been extracted out of the
tarball job into a dedicated one.
Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on #infra. Feel free to merge once you're confident (e.g. via CI) that this doesn't break unexpected things.

@mweinelt mweinelt merged commit 2bdd06e into NixOS:master Apr 20, 2024
13 of 14 checks passed
@mweinelt mweinelt deleted the fix-unstable-smol-eval branch April 20, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants