Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.github.copilot: 1.172.758 -> 1.180.827 #305633

Merged
merged 1 commit into from
Apr 23, 2024
Merged

vscode-extensions.github.copilot: 1.172.758 -> 1.180.827 #305633

merged 1 commit into from
Apr 23, 2024

Conversation

Tobi34
Copy link
Contributor

@Tobi34 Tobi34 commented Apr 20, 2024

Description of changes

updated vscode-extension-github-copilot and vscode-extension-github-copilot-chat version to make it compatible with vscode 1.88.1 (nixpkgs-unstable).

Things done

I have identified working versions with nix4vscode and tried the versions localy with extensionsFromVscodeMarketplace on my local PC.

@Tobi34 Tobi34 requested a review from jonringer as a code owner April 20, 2024 21:28
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Apr 20, 2024
@ofborg ofborg bot requested review from Laurent2916 and Zimmi48 April 20, 2024 21:55
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 20, 2024
@superherointj
Copy link
Contributor

Please, split the commits per package. Instructions at:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/editors/vscode/extensions/README.md

Copy link
Member

@Laurent2916 Laurent2916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that copilot 1.180.827 and copilot-chat 0.14.2024032901 both work on vscode v1.88.1

@@ -1773,8 +1773,8 @@ let
mktplcRef = {
publisher = "github";
name = "copilot-chat";
version = "0.13.2024022301"; # compatible with vscode >= 1.87
hash = "sha256-WdojLEdrg6iqTH/cNPEWb6VEfk+gIHh2M5GHrAURjy8=";
version = "0.14.2024032901"; # copatible with vscode 1.88.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "0.14.2024032901"; # copatible with vscode 1.88.1
version = "0.14.2024032901"; # compatible with vscode 1.88.1

@Laurent2916
Copy link
Member

Result of nixpkgs-review pr 305633 run on x86_64-linux 1

2 packages built:
  • vscode-extensions.github.copilot
  • vscode-extensions.github.copilot-chat

@superherointj superherointj changed the title updated copliot and copilot-chat to be compatible with vscode 1.88.1 vscode-extensions: update github.{copilot,copilot-chat} Apr 21, 2024
@superherointj superherointj changed the title vscode-extensions: update github.{copilot,copilot-chat} vscode-extensions: update github.copilot, github.copilot-chat Apr 21, 2024
@superherointj superherointj changed the title vscode-extensions: update github.copilot, github.copilot-chat vscode-extensions.github.copilot: 1.172.758 -> 1.180.827 Apr 21, 2024
@superherointj
Copy link
Contributor

Commit message should be: vscode-extensions.github.copilot: 1.172.758 -> 1.180.827

Notice, when building, you run: nix build .#vscode-extensions.github.copilot (package github.copilot is not that)

@superherointj superherointj merged commit fabeab4 into NixOS:master Apr 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: vscode 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle! awaiting_changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants