nixos-rebuild: Add missing passed-through options to man page and completion #305639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes the deprecated alias for --offline Since 2021-02-07 in `nix`. See: 37352aa Fixes NixOS#16770
By documenting it is possibly going away at some point?
Some Nix options were not handled. The repl command was added.
I want to be notified on changes, so that I can ~~nag about~~ ensure the bash completions don't drift apart from the implementation. I will try to keep in mind that the manpage needs to be synced at the same time.
github-actions
bot
added
6.topic: nixos
rjpcasalino
reviewed
Apr 30, 2024
samrose
reviewed
Apr 30, 2024
rjpcasalino
reviewed
Apr 30, 2024
The same errors are in Though since the ban is temporary, not an issue. |
SuperSandro2000
approved these changes
Jun 2, 2024
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is syncing the man page and bash completion with the options. This fixes #16770.
In addition it adds the
replcommand to the bash completion.I'm also adding myself to CODEOWNERS to ensure the bash completion doesn't drift again.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.