Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] gst_all_1.*,python3Packages.gst-python: follow-up for 1.22.9 -> 1.24.2 bump #306016

Merged
merged 9 commits into from
Apr 23, 2024
Merged

[staging-next] gst_all_1.*,python3Packages.gst-python: follow-up for 1.22.9 -> 1.24.2 bump #306016

merged 9 commits into from
Apr 23, 2024

Conversation

lilyinstarlight
Copy link
Member

@lilyinstarlight lilyinstarlight commented Apr 22, 2024 •
edited
Loading

Description of changes

Major GStreamer bump (https://gstreamer.freedesktop.org/releases/1.24/)

Fixes #287253

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • x86_64-linux -> aarch64-linux (cross) (in-progress)
    • x86_64-linux (with qt5Support override via nheko)
    • x86_64-linux (with gtkSupport override via pitivi)
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lilyinstarlight lilyinstarlight linked an issue Apr 22, 2024 that may be closed by this pull request
Update request: gst_all_1.gstreamer: 1.22.8 → 1.24.2 #287253
Closed
@lilyinstarlight
Copy link
Member Author

@ofborg eval
(requesting since eval failed due to unrelated reasons on staging earlier)

@lilyinstarlight lilyinstarlight marked this pull request as draft April 22, 2024 21:17
@lilyinstarlight lilyinstarlight changed the base branch from staging to staging-next April 22, 2024 21:17
@lilyinstarlight lilyinstarlight marked this pull request as ready for review April 22, 2024 21:17
@lilyinstarlight
Copy link
Member Author

Rebased on now-merged GNOME 46 PR, which included some of this update already

@lilyinstarlight lilyinstarlight changed the title gst_all_1.*,python3Packages.gst-python: 1.22.9 -> 1.24.2 gst_all_1.*,python3Packages.gst-python: follow-up for 1.22.9 -> 1.24.2 bump Apr 22, 2024
@lilyinstarlight lilyinstarlight changed the title gst_all_1.*,python3Packages.gst-python: follow-up for 1.22.9 -> 1.24.2 bump [staging-next] gst_all_1.*,python3Packages.gst-python: follow-up for 1.22.9 -> 1.24.2 bump Apr 22, 2024
amaxine
amaxine reviewed Apr 22, 2024
View reviewed changes
pkgs/development/libraries/gstreamer/good/default.nix
@@ -148,6 +147,7 @@ stdenv.mkDerivation rec {
]) ++ lib.optionals stdenv.isDarwin [
Cocoa
] ++ lib.optionals stdenv.isLinux [
libdrm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, I caught myself breaking this in base but not good.

amaxine
amaxine approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gst parts of the diff (and especially fixing my mistakes around darwin) look good.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 22, 2024
@ofborg ofborg bot requested review from matthewbauer and jansol April 22, 2024 22:56
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 23, 2024
jansol
jansol approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@jansol jansol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

liblc3 changes lgtm

vcunat
vcunat requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR breaks the hotdoc build for me. Same error on x86_64-linux and aarch64-darwin:

hotdoc-0.16/lib/python3.11/site-packages/hotdoc/core/tests/test_page.py::TestPage::test_meta_schema - AssertionError: InvalidPageMetadata not raised

vcunat added a commit that referenced this pull request Apr 23, 2024
@vcunat
Revert "hotdoc: 0.15 -> 0.16"
57f6ac6 
This reverts commit 7cf0402.
It breaks the build for me (on x86_64-linux and aarch64-darwin),
and I fail to see why the update is even needed, so let's not do it now.
/cc PR #306016
vcunat added a commit that referenced this pull request Apr 23, 2024
@vcunat
Merge #306016: gst_all_1.*: follow-up for 1.22.9 -> 1.24.2 bump
6cbdbb6 
...into staging-next
@vcunat vcunat merged commit 73d8996 into NixOS:staging-next Apr 23, 2024
34 of 35 checks passed
@vcunat
Copy link
Member

vcunat commented Apr 23, 2024

With the hotdoc update reverted it looked OK, so I took that. Hopefully this stabilization of everything won't be too rough.

@lilyinstarlight lilyinstarlight deleted the upd/gstreamer-1.24 branch May 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat requested changes

@amaxine amaxine amaxine approved these changes

@jansol jansol jansol approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: gst_all_1.gstreamer: 1.22.8 → 1.24.2
5 participants
@lilyinstarlight @vcunat @jansol @amaxine @wegank