Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-23.11] llvm: stop running strip-preserve-atime.test #306061

Conversation

harrisonkaiser
Copy link

@harrisonkaiser harrisonkaiser commented Apr 22, 2024

This test fails in the presence of anti-virus software or other intrusion-detection software that modifies the atime when run.

See #284056 and llvm/llvm-project#82372.

(cherry picked from commit 7201396)

Description of changes

This is a backport of a change that is on nixpkgs-unstable. That I need on 23.11 to build llvm on mac os.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This test fails in the presence of anti-virus software or other
intrusion-detection software that modifies the atime when run.

See NixOS#284056 and llvm/llvm-project#82372.

(cherry picked from commit 7201396)
@harrisonkaiser
Copy link
Author

Confirmed the build worked on aarch darwin.

@harrisonkaiser
Copy link
Author

harrisonkaiser commented Apr 22, 2024

Looks like the unexpected error of llvm, llvm.passthru.tests on x86_64-darwin was a timeout:

error: building of '/nix/store/yfcqwv66nzmqg3fpy35lnr1q7cnp94c0-llvm-16.0.6.drv^out' from .drv file timed out after 3600 seconds

@harrisonkaiser harrisonkaiser changed the title llvm: stop running strip-preserve-atime.test [Backport release-23.11] llvm: stop running strip-preserve-atime.test Apr 23, 2024
@wegank
Copy link
Member

wegank commented Jun 30, 2024

As NixOS 23.11 reaches end-of-life today, this PR is closed as part of the EOL cleanup.

@wegank wegank closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants