-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNOME 46 fixes #306469
GNOME 46 fixes #306469
Conversation
gobject-instrospection before version 1.80 shipped typelibs for GLib. As a result, programs relying on libgirepository such as those using pygobject3 would find the GLib typelibs without being wrapped at all. In GNOME 46, the GLib typelibs were moved to glib package. So if we want a program to find them, they need to be explicitly passed through `GI_TYPELIB_PATH` environment variable. This can be demonstrated by running `GI_TYPELIB_PATH= powerprofilesctl`: ImportError: cannot import name Gio, introspection typelib not found Let’s add the library to path using a wrapper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for catching that ppd needs wrapping now.
rev = "v${version}"; | ||
sha256 = "sha256-MpoeLXGdLfas/E3x5ojJW5Dd3H8XZORtFaBHgRGJXxg="; | ||
src = fetchurl { | ||
url = "https://www.imagination-land.org/files/gpaste/GPaste-${finalAttrs.version}.tar.xz"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really does look dodgy, thanks for the comment confirming you verified the contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It always promoted tarballs hosted on the author’s website. We just ignored them.
There is an issue requesting for the tag: Keruspe/GPaste#443
GNOME 46 support! https://www.imagination-land.org/posts/2024-03-21-gpaste-45.1-released.html No tag yet. Checked that v45 tarball matches the git repo and that 45.1 diff is okay. Also clean up the expression and fix license.
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.