Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snes9x: 1.62.3 -> 1.62.3-unstable-2024-04-22 #306652

Merged
merged 2 commits into from
Apr 25, 2024
Merged

snes9x: 1.62.3 -> 1.62.3-unstable-2024-04-22 #306652

merged 2 commits into from
Apr 25, 2024

Conversation

AndersonTorres
Copy link
Member

Description of changes

Things done

Closes #306639

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review April 24, 2024 23:24
@ofborg ofborg bot requested review from qknight and thiagokokada April 24, 2024 23:50
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 24, 2024
@AndersonTorres
snes9x: 1.62.3 -> 1.62.3-unstable-2024-04-22
306c53d 
- finalAttrs design pattern
- split outputs
- reorder buildInputs
  - libselinux and util-linuxMinimal are obviously Linux-only
- get rid of nested with
- Add AndersonTorres as maintainer
@AndersonTorres
snes9x: migrate to by-name
aebbcc1
@ofborg ofborg bot requested a review from thiagokokada April 25, 2024 11:13
@AndersonTorres
Copy link
Member Author

P.S.: it now has support to Qt.
Maybe I should try this later.

@thiagokokada thiagokokada merged commit 3a23d44 into NixOS:master Apr 25, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: snes9x-gtk
2 participants
@AndersonTorres @thiagokokada