Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeinfo: init at 0.3.2 #307090

Merged
merged 1 commit into from
May 14, 2024
Merged

nodeinfo: init at 0.3.2 #307090

merged 1 commit into from
May 14, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 26, 2024

Description of changes

Package nodeinfo an cli tool that query's nodeinfo based on a given domain

https://codeberg.org/thefederationinfo/nodeinfo-go

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Apr 27, 2024
pkgs/by-name/no/nodeinfo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/nodeinfo/package.nix Outdated Show resolved Hide resolved
@xzfc
Copy link
Contributor

xzfc commented Apr 27, 2024

Build fails:

nix-repl> :b nodeinfo
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'nodeinfo-0.3.2'
         whose name attribute is located at /home/user/.cache/nixpkgs-review/pr-307090-3/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:331:7

       … while evaluating attribute 'configurePhase' of derivation 'nodeinfo-0.3.2'

         at /home/user/.cache/nixpkgs-review/pr-307090-3/nixpkgs/pkgs/build-support/go/module.nix:173:5:

          172|
          173|     configurePhase = args.configurePhase or (''
             |     ^
          174|       runHook preConfigure

       error: buildGoModule: vendorHash is missing

@6543

This comment was marked as outdated.

@6543
Copy link
Member Author

6543 commented May 10, 2024

@xzfc works now :)

@6543 6543 requested a review from xzfc May 10, 2024 17:43
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 10, 2024
Copy link
Contributor

@xzfc xzfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits. Your PR should have a single commit with name nodeinfo: init at 0.3.2 and no commits like nodeinfo: address review.

pkgs/by-name/no/nodeinfo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/nodeinfo/package.nix Show resolved Hide resolved
pkgs/by-name/no/nodeinfo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/no/nodeinfo/package.nix Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented May 12, 2024

done :)

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 13, 2024
@6543
Copy link
Member Author

6543 commented May 13, 2024

how many approvals do i need?

@Aleksanaa Aleksanaa merged commit ea9b756 into NixOS:master May 14, 2024
25 checks passed
@6543 6543 deleted the nodeinfo branch May 14, 2024 11:17
Copy link
Contributor

Successfully created backport PR for release-23.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants