neovimUtils.grammarToPlugin: remove vimplugin prefix #307167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerchunPak
force-pushed
the
fix-treesitter-grammars-prefix
branch
from
6169ebf
to
302fe72
Compare
|
Result of 274 packages built:
Will post results of |
|
Ended up cherry-picking d9cf422 to nixos-unstable (7bb2ccd), anyway here are results: Result of 1 package marked as broken and skipped:
365 packages built:
I also wrote a script that gave me a name of every of those packages and found out that only treesitter grammars were affected. |
teto
reviewed
Apr 28, 2024
PerchunPak
force-pushed
the
fix-treesitter-grammars-prefix
branch
from
302fe72
to
9bc088c
Compare
PerchunPak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a PR to fix issue I found here, I also added fix in second commit which ensures same error won't happen with other packages. This is targeted
staging-nextbecause it fixes a small mass rebuild of treesitter grammars (which is 20-50 packages, I don't really know how to count them).Please let me know if I should change name of the PR, because I don't really know how to name it differently.
cc @teto as author of #303200 and @vcunat as author of #306080
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.