Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] anydesk: 6.3.0 -> 6.3.2 #307183

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Apr 27, 2024

Description of changes

Backport of #306850.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 307183 run on x86_64-linux 1

1 package built:
  • anydesk

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from cheriimoya and shyim April 27, 2024 11:08
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 27, 2024
Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should manually cherry-pick all other commits, including a7e26c5

@gepbird gepbird force-pushed the backport-306850-to-release-23.11 branch from 0644591 to b6197d2 Compare April 27, 2024 12:13
@gepbird
Copy link
Contributor Author

gepbird commented Apr 27, 2024

Thanks @JohnRTitor, done.
Should we also backport other changes like ae8abf3 or only version bumps?

@JohnRTitor
Copy link
Contributor

Yes, do backport all previous commits, that haven't been in release/23.11 to prevent breakage.

@ofborg ofborg bot requested a review from shyim April 27, 2024 12:34
SuperSandro2000 and others added 4 commits April 27, 2024 14:34
(cherry picked from commit ae8abf3)
(cherry picked from commit a7e26c5)
(cherry picked from commit 1af4a76)
@gepbird gepbird force-pushed the backport-306850-to-release-23.11 branch from b6197d2 to 323bf57 Compare April 27, 2024 12:36
@JohnRTitor JohnRTitor added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 27, 2024
@NickCao NickCao merged commit 08f49cc into NixOS:release-23.11 Apr 27, 2024
23 of 24 checks passed
@gepbird gepbird deleted the backport-306850-to-release-23.11 branch April 27, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants