Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tex-fmt: init at 0.1.0 #307295

Closed
wants to merge 394 commits into from
Closed

tex-fmt: init at 0.1.0 #307295

wants to merge 394 commits into from

Conversation

WGUNDERWOOD
Copy link
Contributor

@WGUNDERWOOD WGUNDERWOOD commented Apr 27, 2024 •
edited
Loading

Description of changes

tex-fmt is a LaTeX formatter written in Rust.
https://github.com/WGUNDERWOOD/tex-fmt/
It is a work in progress but the current version v0.1.0 has basic functionality.

Things done

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Apr 27, 2024
@github-actions github-actions bot added 6.topic: TeX Issues regarding texlive and TeX in general and removed 6.topic: TeX Issues regarding texlive and TeX in general labels Apr 27, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 27, 2024
yunfachi
yunfachi suggested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@yunfachi yunfachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the pull request to tex-fmt: init at 0.1.0 and leave two commits with these messages:

maintainers: add wgunderwood
tex-fmt: init at 0.1.0

pkgs/by-name/te/tex-fmt/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/tex-fmt/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/tex-fmt/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/te/tex-fmt/package.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@WGUNDERWOOD WGUNDERWOOD force-pushed the add-tex-fmt branch 2 times, most recently from ca17678 to 5e6911c Compare April 28, 2024 17:53
@yunfachi
Copy link
Member

LGTM, but the tex-fmt: init at 0.1.0 commit should be after maintainers: add wgunderwood.

@WGUNDERWOOD
Copy link
Contributor Author

LGTM, but the tex-fmt: init at 0.1.0 commit should be after maintainers: add wgunderwood.

I have switched the order of these commits.

@WGUNDERWOOD WGUNDERWOOD changed the title adding new tex-fmt package tex-fmt: init at 0.1.0 Apr 28, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild labels Apr 29, 2024
@WGUNDERWOOD
Copy link
Contributor Author

@yunfachi @AndersonTorres Let me know if any more changes are required, and thanks for all your help with this.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde 6.topic: kernel The Linux kernel 8.has: documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: policy discussion 6.topic: vim 6.topic: ocaml 6.topic: nodejs 6.topic: lib The Nixpkgs function library 6.topic: zig 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Jul 6, 2024
@WGUNDERWOOD WGUNDERWOOD closed this Jul 6, 2024
@WGUNDERWOOD WGUNDERWOOD deleted the add-tex-fmt branch July 6, 2024 19:46
@NixOS NixOS locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndersonTorres AndersonTorres AndersonTorres left review comments

@yunfachi yunfachi yunfachi approved these changes

@figsoda figsoda Awaiting requested review from figsoda

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

@adisbladis adisbladis Awaiting requested review from adisbladis

@mweinelt mweinelt Awaiting requested review from mweinelt

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@ttuegel ttuegel Awaiting requested review from ttuegel

@alyssais alyssais Awaiting requested review from alyssais

@emilylange emilylange Awaiting requested review from emilylange

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

@natsukium natsukium Awaiting requested review from natsukium

@JulienMalka JulienMalka Awaiting requested review from JulienMalka

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

Assignees
No one assigned
Labels
6.topic: emacs Text editor 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: kernel The Linux kernel 6.topic: lib The Nixpkgs function library 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 6.topic: ocaml 6.topic: policy discussion 6.topic: python 6.topic: qt/kde 6.topic: vim 6.topic: zig 8.has: changelog 8.has: documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.