Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] libarchive: apply patch for CVE-2024-26256 and ZIP OOB #307311

Merged

Conversation

LeSuisse
Copy link
Contributor

Description of changes

References:
GHSA-2jc9-36w4-pmqw
libarchive/libarchive#2145

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 27, 2024
@vcunat vcunat merged commit 48aa58b into NixOS:staging-23.11 Apr 28, 2024
8 of 10 checks passed
@risicle
Copy link
Contributor

risicle commented Apr 28, 2024

Patches LGTM, cherry-picked to release-23.11 for testing, build passthru.tests on macos 12 x86_64 & nixos x86_64. Built pkgsStatic, pkgsCross.aarch64-multiplatform, pkgsi686Linux variants.

@LeSuisse LeSuisse deleted the libarchive-CVE-2024-26256-zip-oob branch April 29, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants