mathemagix: add configure parameters #307556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonTorres
suggested changes
Apr 28, 2024
| @@ -8,6 +8,18 @@ | |||
| libtool, | |||
| gmp, | |||
| mpfr, | |||
| enable-algebramix ? true, | |||
There was a problem hiding this comment.
- As far as I remember, the current status quo is to use camelCase (
enableAlgebramix) - [RFC 0169] Feature parameter names rfcs#169 suggests snake case (
enable_algebramix), because Bash has some problems with hyphenated names.
Comment on lines
37
to
38
| configureFlags = lib.optionals enable-algebramix [ | ||
| "--enable-algebramix" |
There was a problem hiding this comment.
Suggested change
| configureFlags = lib.optionals enable-algebramix [ | |
| "--enable-algebramix" | |
| configureFlags = [ | |
| (lib.enableFeature enableAlgebramix "algebramix") |
and repeat the pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.