-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_86BoxManagerX: init at 1.7.6.0-e #307611
Draft
jchv
wants to merge
1
commit into
NixOS:master
Choose a base branch
from
jchw-forks:init/86box-manager-x
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Apr 29, 2024
jchv
force-pushed
the
init/86box-manager-x
branch
3 times, most recently
from
November 1, 2024 15:47
51e7863
to
dfa57fd
Compare
Changelog from 4aae854 to faab013:
Changelog from faab013 to 51e7863:
Changelog from 51e7863 to dfa57fd:
|
jchv
force-pushed
the
init/86box-manager-x
branch
from
November 2, 2024 18:00
dfa57fd
to
2b0bb70
Compare
FliegendeWurst
requested changes
Dec 6, 2024
Comment on lines
+76
to
+77
dotnet-sdk = dotnetCorePackages.sdk_6_0; | ||
dotnet-runtime = dotnetCorePackages.runtime_6_0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.NET 6 will be removed #326335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/RetBox/86BoxManagerX
86BoxManagerX is a cross-platform fork of 86BoxManager, a configuration manager for 86Box. 86BoxManagerX makes it easy to manage multiple different machine configurations using 86Box.
In order to integrate it well into Nixpkgs, the following patches were made:
$XDG_CONFIG_HOME
rather than the directory of the assembly, which would point into the read-only Nix store. This is adapted from a pending pull request.The justification for this is a result of the way 86BoxManagerX works: at first startup, it creates the configuration files after detecting the path to 86Box, and encodes the path to 86Box into the configuration file. After this, it does not try to find the 86Box executable again, even if it stops existing. It would be nice if the configuration could override the hardcoded path, but that'd be a much more involved patch, whereas this one is almost entirely just removing things, which should be easy to deal with. Adding upstream support for the hardcoded path might make this easier in the future.
P.S.: The reason the
version
string differs from the tag in having an additional hyphen is becausebuildDotnetModule
disallows the string1.7.6.0e
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.