Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] iwd: apply patches for CVE-2023-52161 and buffer overflows #308218

Merged
merged 1 commit into from
May 3, 2024

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented May 1, 2024

Description of changes

AFAIK the buffer overflows did not get a CVE ID assigned and I'm not sure it can be exploited in a meaningful way. The patches are pretty small and self contained so it should be fine to include them "just in case".

unstable is using the latest version that include all the patches.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 308218 run on x86_64-linux 1

4 packages built:
  • iwd
  • iwd.doc
  • iwd.man
  • iwd.test

Add a 👍 reaction to pull requests you find important.

@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 1, 2024
@ofborg ofborg bot requested review from dtzWill, amaxine and fpletz May 1, 2024 09:39
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 1, 2024
@amaxine amaxine removed their request for review May 1, 2024 09:40
Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. More buffer overflows in iwd sigh

@leona-ya leona-ya merged commit 6205fb4 into NixOS:release-23.11 May 3, 2024
28 checks passed
@LeSuisse LeSuisse deleted the iwd-CVE-2023-52161-23.11 branch May 3, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants