Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.11] nextcloud29: init at 29.0.0, nextcloud28: 28.0.4 -> 28.0.5, nextcloud27: 27.1.8 -> 27.1.9 #308261

Merged
merged 5 commits into from
May 7, 2024
Merged

[23.11] nextcloud29: init at 29.0.0, nextcloud28: 28.0.4 -> 28.0.5, nextcloud27: 27.1.8 -> 27.1.9 #308261

merged 5 commits into from
May 7, 2024

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 1, 2024

Description of changes

Backport of #306595 minus breaking changes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Ma27 and others added 4 commits May 1, 2024 14:01
@Ma27
nextcloud27: 27.1.8 -> 27.1.9
0b77602 
ChangeLog: https://nextcloud.com/changelog/#27-1-9
(cherry picked from commit 5a3bc43)
@Ma27
nextcloud28: 28.0.4 -> 28.0.5
726397c 
ChangeLog: https://nextcloud.com/changelog/#28-0-5
(cherry picked from commit acd2192)
@RaitoBezarius @Ma27
nextcloud29: init at 29.0.0
aeee2b9 
Signed-off-by: Raito Bezarius <[email protected]>
(cherry picked from commit 3ebf8d0)
@Ma27
nextcloud*Packages: update
af14a1c 
Seems to fix the phonetrack issue.

(cherry picked from commit f082e0d)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 1, 2024
@Ma27 Ma27 mentioned this pull request May 1, 2024
Merged
13 tasks
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 1, 2024
@ofborg ofborg bot requested review from bachp, schneefux and globin May 1, 2024 12:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 1, 2024
@jtrees
Copy link
Contributor

jtrees commented May 4, 2024

I'm a bit surprised to see NC 29 in the backport. Is that normal procedure for nixpkgs?

@Ma27
Copy link
Member Author

Ma27 commented May 4, 2024

It gives people a longer window to upgrade.
Remember that the default won't change, i.e. it remains nextcloud28 on 23.11, but you can exchange it with nextcloud29.
And backporting new packages (this fits the definition IMHO) is allowed.

@risicle
Copy link
Contributor

risicle commented May 4, 2024

Check-cherry-picks "failure" understandable.

@Ma27
nixos/nextcloud: add trailing slashes to carddav/caldav redirect
e633f8b 
This seems to solve the problem with the warning about carddav/caldav
redirects being broken.
@Ma27 Ma27 mentioned this pull request May 5, 2024
Merged
13 tasks
@Ma27
Copy link
Member Author

Ma27 commented May 5, 2024

@risicle yeah only a portion is reasonable to backport. Do you prefer to remove the 'cherry picked from'-part of the commit?

@risicle
Copy link
Contributor

risicle commented May 5, 2024

No I think it's fine. I have a PR #305628 to suppress hard-failures on warnings, but it has some issues of its own due to github jankiness.

@dasJ dasJ merged commit b4c7796 into NixOS:release-23.11 May 7, 2024
21 of 22 checks passed
@Ma27 Ma27 deleted the nextcloud-2311 branch May 7, 2024 10:02
@philipwilk
Copy link
Contributor

philipwilk commented May 11, 2024 •
edited
Loading

image
Seems broken updating from 28.04 or 28.05 to 29

@Ma27
Copy link
Member Author

Ma27 commented May 12, 2024

Which nixpkgs rev?
Also, as indicated by the error message, your data directory has uid 1000 as owner, but nextcloud seems to be 994. Why?

@philipwilk
Copy link
Contributor

So I've just checked the data dir and it was indeed owned by my user instead of nextcloud, chown-ing the entire thing to nextcloud fixed it.
Bit confused why every previous version didn't complain about this but whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp Awaiting requested review from bachp

@schneefux schneefux Awaiting requested review from schneefux

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ma27 @jtrees @risicle @philipwilk @dasJ @RaitoBezarius