Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] python3Packages.aiohttp: apply patches for CVE-2024-30251 #308764

Merged
merged 1 commit into from
May 4, 2024

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented May 3, 2024

Description of changes

GHSA-5m98-qgg9-wh84

A slight adjustment has been made to cebe526b9c34dc3a3da9140409db63014bc4cf19 in order to resolve a conflict in tests/test_client_functional.py.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Built with nixpkgs-review pr --package-regex 'python.*aiohttp.*' 308764:

Result of nixpkgs-review pr 308764 run on x86_64-linux 1

60 packages built:
  • python310Packages.aiohttp
  • python310Packages.aiohttp-apispec
  • python310Packages.aiohttp-apispec.dist
  • python310Packages.aiohttp-basicauth
  • python310Packages.aiohttp-basicauth.dist
  • python310Packages.aiohttp-cors
  • python310Packages.aiohttp-cors.dist
  • python310Packages.aiohttp-jinja2
  • python310Packages.aiohttp-jinja2.dist
  • python310Packages.aiohttp-oauthlib
  • python310Packages.aiohttp-oauthlib.dist
  • python310Packages.aiohttp-openmetrics
  • python310Packages.aiohttp-openmetrics.dist
  • python310Packages.aiohttp-remotes
  • python310Packages.aiohttp-remotes.dist
  • python310Packages.aiohttp-retry
  • python310Packages.aiohttp-retry.dist
  • python310Packages.aiohttp-socks
  • python310Packages.aiohttp-socks.dist
  • python310Packages.aiohttp-swagger
  • python310Packages.aiohttp-swagger.dist
  • python310Packages.aiohttp-wsgi
  • python310Packages.aiohttp-wsgi.dist
  • python310Packages.aiohttp.dist
  • python310Packages.opentelemetry-instrumentation-aiohttp-client
  • python310Packages.opentelemetry-instrumentation-aiohttp-client.dist
  • python310Packages.pytest-aiohttp
  • python310Packages.pytest-aiohttp.dist
  • python310Packages.webtest-aiohttp
  • python310Packages.webtest-aiohttp.dist
  • python311Packages.aiohttp
  • python311Packages.aiohttp-apispec
  • python311Packages.aiohttp-apispec.dist
  • python311Packages.aiohttp-basicauth
  • python311Packages.aiohttp-basicauth.dist
  • python311Packages.aiohttp-cors
  • python311Packages.aiohttp-cors.dist
  • python311Packages.aiohttp-jinja2
  • python311Packages.aiohttp-jinja2.dist
  • python311Packages.aiohttp-oauthlib
  • python311Packages.aiohttp-oauthlib.dist
  • python311Packages.aiohttp-openmetrics
  • python311Packages.aiohttp-openmetrics.dist
  • python311Packages.aiohttp-remotes
  • python311Packages.aiohttp-remotes.dist
  • python311Packages.aiohttp-retry
  • python311Packages.aiohttp-retry.dist
  • python311Packages.aiohttp-socks
  • python311Packages.aiohttp-socks.dist
  • python311Packages.aiohttp-swagger
  • python311Packages.aiohttp-swagger.dist
  • python311Packages.aiohttp-wsgi
  • python311Packages.aiohttp-wsgi.dist
  • python311Packages.aiohttp.dist
  • python311Packages.opentelemetry-instrumentation-aiohttp-client
  • python311Packages.opentelemetry-instrumentation-aiohttp-client.dist
  • python311Packages.pytest-aiohttp
  • python311Packages.pytest-aiohttp.dist
  • python311Packages.webtest-aiohttp
  • python311Packages.webtest-aiohttp.dist

Result of nixpkgs-review pr 308764 run on aarch64-linux 1

4 packages failed to build:
  • python310Packages.aiohttp-apispec
  • python310Packages.aiohttp-apispec.dist
  • python311Packages.aiohttp-apispec
  • python311Packages.aiohttp-apispec.dist
56 packages built:
  • python310Packages.aiohttp
  • python310Packages.aiohttp-basicauth
  • python310Packages.aiohttp-basicauth.dist
  • python310Packages.aiohttp-cors
  • python310Packages.aiohttp-cors.dist
  • python310Packages.aiohttp-jinja2
  • python310Packages.aiohttp-jinja2.dist
  • python310Packages.aiohttp-oauthlib
  • python310Packages.aiohttp-oauthlib.dist
  • python310Packages.aiohttp-openmetrics
  • python310Packages.aiohttp-openmetrics.dist
  • python310Packages.aiohttp-remotes
  • python310Packages.aiohttp-remotes.dist
  • python310Packages.aiohttp-retry
  • python310Packages.aiohttp-retry.dist
  • python310Packages.aiohttp-socks
  • python310Packages.aiohttp-socks.dist
  • python310Packages.aiohttp-swagger
  • python310Packages.aiohttp-swagger.dist
  • python310Packages.aiohttp-wsgi
  • python310Packages.aiohttp-wsgi.dist
  • python310Packages.aiohttp.dist
  • python310Packages.opentelemetry-instrumentation-aiohttp-client
  • python310Packages.opentelemetry-instrumentation-aiohttp-client.dist
  • python310Packages.pytest-aiohttp
  • python310Packages.pytest-aiohttp.dist
  • python310Packages.webtest-aiohttp
  • python310Packages.webtest-aiohttp.dist
  • python311Packages.aiohttp
  • python311Packages.aiohttp-basicauth
  • python311Packages.aiohttp-basicauth.dist
  • python311Packages.aiohttp-cors
  • python311Packages.aiohttp-cors.dist
  • python311Packages.aiohttp-jinja2
  • python311Packages.aiohttp-jinja2.dist
  • python311Packages.aiohttp-oauthlib
  • python311Packages.aiohttp-oauthlib.dist
  • python311Packages.aiohttp-openmetrics
  • python311Packages.aiohttp-openmetrics.dist
  • python311Packages.aiohttp-remotes
  • python311Packages.aiohttp-remotes.dist
  • python311Packages.aiohttp-retry
  • python311Packages.aiohttp-retry.dist
  • python311Packages.aiohttp-socks
  • python311Packages.aiohttp-socks.dist
  • python311Packages.aiohttp-swagger
  • python311Packages.aiohttp-swagger.dist
  • python311Packages.aiohttp-wsgi
  • python311Packages.aiohttp-wsgi.dist
  • python311Packages.aiohttp.dist
  • python311Packages.opentelemetry-instrumentation-aiohttp-client
  • python311Packages.opentelemetry-instrumentation-aiohttp-client.dist
  • python311Packages.pytest-aiohttp
  • python311Packages.pytest-aiohttp.dist
  • python311Packages.webtest-aiohttp
  • python311Packages.webtest-aiohttp.dist

The test failures I got on aiohttp-apispec do not seem to be related to this change.

Add a 👍 reaction to pull requests you find important.

GHSA-5m98-qgg9-wh84

A slight adjustment has been made to cebe526b9c34dc3a3da9140409db63014bc4cf19 in order
to resolve a conflict in `tests/test_client_functional.py`.
@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 3, 2024
@LeSuisse LeSuisse changed the title python3Packages.aiohttp: apply patches for CVE-2024-30251 [23.11] python3Packages.aiohttp: apply patches for CVE-2024-30251 May 3, 2024
@ofborg ofborg bot requested a review from dotlambda May 3, 2024 10:17
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 3, 2024
@drupol drupol merged commit 6a03749 into NixOS:staging-23.11 May 4, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants