Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildMavenPackage: add doCheck support #316765

Merged
merged 11 commits into from
Jun 4, 2024

Conversation

superherointj
Copy link
Contributor

  • buildMavenPackage: add doCheck support
  • normalize doCheck: h2, kotlin-interactive-shell, sonarlint-ls, ns-usbloader, openrefine, commafeed, java-language-server, forge-mtg, mariadb-connector-java, s3proxy

@AndersonTorres
Copy link
Member

AndersonTorres commented Jun 3, 2024

  1. I am dealing with these files too: Maven: refactor #316764
  2. cko, the maintainer of Maven, is on the retirements list: [Tracking issue] Silent retirement of maintainers #290642

What do you think about merge both PRs?

@superherointj
Copy link
Contributor Author

superherointj commented Jun 3, 2024

  1. I am dealing with these files too: Maven: refactor #316764

What a coincidence of timing. This was on my queue for quite some time.

What do you think about merge both PRs?

By merge, unify as one?
Wouldn't be simpler to just merge this first. (Because it's simple and straightforward. Only one file conflicts minimally.)
And then I review your PR.

@AndersonTorres
Copy link
Member

Nice. I will wait your PR, then.

@superherointj superherointj marked this pull request as draft June 3, 2024 00:29
@superherointj
Copy link
Contributor Author

superherointj commented Jun 3, 2024

Result of nixpkgs-review pr 316765 run on x86_64-linux 1

1 package failed to build:
  • jd-cli [Already failing in master, unrelated]
27 packages built:
  • apgdiff
  • bytecode-viewer
  • certificate-ripper
  • commafeed
  • cryptomator
  • digital
  • forge-mtg
  • gephi
  • global-platform-pro
  • h2
  • h2.doc
  • java-language-server
  • jugglinglab
  • kotlin-interactive-shell
  • ktfmt
  • lemminx
  • mariadb-connector-java
  • ns-usbloader
  • openrefine
  • quark-goldleaf
  • runelite
  • s3proxy
  • scenebuilder
  • schemaspy
  • slipstream
  • sonarlint-ls
  • tabula-java

@superherointj superherointj marked this pull request as ready for review June 3, 2024 00:49
@superherointj superherointj requested review from pluiedev, tricktron and starsep and removed request for pluiedev June 4, 2024 17:24
@superherointj superherointj merged commit 1993b60 into NixOS:master Jun 4, 2024
26 checks passed
@superherointj superherointj deleted the maven-add-doCheck-support branch June 4, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants