Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cko from maintainers #316769

Closed
wants to merge 3 commits into from
Closed

Remove cko from maintainers #316769

wants to merge 3 commits into from

Conversation

AndersonTorres
Copy link
Member

Following #290642

Pinging @cko

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
git-extras: remove cko from maintainers
fcdc10e 
Since theey is not active anymore.
@AndersonTorres
nodejs: remove cko from maintainers
72f0546 
Since theey is not active anymore.
@AndersonTorres
maven: remove cko from maintainers
ee67572 
Since theey is not active anymore.

Warning: orphaned package.
@AndersonTorres AndersonTorres marked this pull request as ready for review June 3, 2024 00:16
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jun 3, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4095

@superherointj superherointj requested a review from cko June 18, 2024 23:12
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 25, 2024
@wegank
Copy link
Member

wegank commented Jul 3, 2024

Merge conflict, please rebase.

@AndersonTorres
Copy link
Member Author

Why is so difficult to remove someone dormant here?

#322266

@AndersonTorres
Copy link
Member Author

Closing as

@wegank
Copy link
Member

wegank commented Jul 3, 2024

I can do another PR on master if you wish.

@AndersonTorres AndersonTorres deleted the remove-cko branch July 3, 2024 15:28
@wegank wegank mentioned this pull request Jul 3, 2024
Merged
13 tasks
@AndersonTorres
Copy link
Member Author

Please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cko cko Awaiting requested review from cko

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndersonTorres @nixos-discourse @wegank