Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/kafka: Added cluster/MirrorMaker testcase #317496

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jpds
Copy link
Contributor

@jpds jpds commented Jun 5, 2024

Description of changes

Adds a Kafka cluster/MirrorMaker testcase.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jun 5, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jun 5, 2024
@jpds jpds force-pushed the nixos-tests-kafka-cluster branch 2 times, most recently from eee44d1 to e3662b6 Compare June 5, 2024 21:40
@jpds jpds force-pushed the nixos-tests-kafka-cluster branch 2 times, most recently from 2836fb7 to 00a7ff7 Compare June 14, 2024 18:44
@jpds jpds changed the title nixos/kafka: Added cluster testcase nixos/kafka: Added cluster/MirrorMaker testcase Jun 14, 2024
@jpds jpds requested a review from ragnard June 26, 2024 20:30
@jpds jpds force-pushed the nixos-tests-kafka-cluster branch 4 times, most recently from 8d66d02 to e5ae1e2 Compare June 26, 2024 21:46
@jpds jpds mentioned this pull request Jul 18, 2024
13 tasks
@pbsds
Copy link
Member

pbsds commented Aug 11, 2024

@ofborg test kafka

Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofborg seems to time out

nixos/tests/kafka/cluster.nix Outdated Show resolved Hide resolved
@jpds jpds force-pushed the nixos-tests-kafka-cluster branch 2 times, most recently from 4fec415 to 3aa653f Compare August 11, 2024 22:05
@jpds
Copy link
Contributor Author

jpds commented Aug 11, 2024

@pbsds On my build box; nix-build -A nixosTests.kafka performs of a build of the 6.6.45 kernel; however - the tests after that pass.

@pbsds
Copy link
Member

pbsds commented Aug 16, 2024

       error: undefined variable 'system'

       at /dev/shm/nixpkgs-review/pr-317496/nixpkgs/nixos/tests/kafka/base.nix:100:7:

           99|     '';
          100|   }) { inherit system; });
             |       ^
          101|

@jpds
Copy link
Contributor Author

jpds commented Sep 9, 2024

@pbsds Thanks for catching that - fixed.

@pbsds
Copy link
Member

pbsds commented Sep 11, 2024

@ofborg test kafka

@pbsds
Copy link
Member

pbsds commented Sep 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants