Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unarc: init at 0-unstable-2020-06-05 #322687

Merged
merged 1 commit into from
Dec 30, 2024
Merged

unarc: init at 0-unstable-2020-06-05 #322687

merged 1 commit into from
Dec 30, 2024

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Jun 26, 2024

Description of changes

Introduces unarc with auto update and meta.mainProgram set up

Signed-off-by: lucasew [email protected]

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor Author

lucasew commented Jun 26, 2024

Result of nixpkgs-review pr 322687 run on x86_64-linux 1

1 package built:
  • unarc

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 26, 2024
@lucasew
Copy link
Contributor Author

lucasew commented Jul 4, 2024

Result of nixpkgs-review pr 322687 run on x86_64-linux 1

1 package built:
  • unarc

FliegendeWurst
FliegendeWurst requested changes Nov 17, 2024
View reviewed changes
pkgs/by-name/un/unarc/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/un/unarc/package.nix Outdated Show resolved Hide resolved
@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Nov 17, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 labels Dec 30, 2024
@lucasew
Copy link
Contributor Author

lucasew commented Dec 30, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 322687

x86_64-linux

✅ 5 packages built:
  • melange
  • terraform-providers.aiven
  • terraform-providers.migadu
  • terraform-providers.sentry
  • unarc

@FliegendeWurst FliegendeWurst removed the awaiting_changes (old Marvin label, do not use) label Dec 30, 2024
@FliegendeWurst FliegendeWurst merged commit 91bec33 into NixOS:master Dec 30, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasew @FliegendeWurst