emulationstation: refactor #324444
Merged
emulationstation: refactor #324444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonTorres
referenced
this pull request
Jul 4, 2024
- finalAttrs design pattern - remove eigen dependency - strictDeps - move resources to $out/share - link resources to $out/bin
AndersonTorres
force-pushed
the
emulationstation
branch
from
cbe9e97
to
5beee08
Compare
kini
reviewed
Jul 4, 2024
13 tasks
Aleksanaa
changed the title
JohnRTitor
reviewed
Jul 12, 2024
|
Since emulationstation needs an insecure freeimage (and I still did not figure out how to fix it), it will not be built by ofBorg. |
Aleksanaa
reviewed
Jul 12, 2024
AndersonTorres
force-pushed
the
emulationstation
branch
2 times, most recently
from
43a611f
to
a75561d
Compare
AndersonTorres
force-pushed
the
emulationstation
branch
2 times, most recently
from
c2cb9b9
to
f2c6a39
Compare
Mental note: I need to automate this!
AndersonTorres
force-pushed
the
emulationstation
branch
from
f2c6a39
to
b88906a
Compare
superherointj
approved these changes
Jul 28, 2024
|
@edwtjo Do you have objections? |
thiagokokada
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by af039eb#r143796136
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.