Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filebrowser: 2.23.0 -> 2.31.0 #326932

Merged
merged 2 commits into from
Sep 3, 2024
Merged

filebrowser: 2.23.0 -> 2.31.0 #326932

merged 2 commits into from
Sep 3, 2024

Conversation

HritwikSinghal
Copy link
Contributor

@HritwikSinghal HritwikSinghal commented Jul 13, 2024 •
edited
Loading

Description of changes

Updated the filebrowser from 2.23.0 to 2.31.0.

https://github.com/filebrowser/filebrowser/blob/master/CHANGELOG.md

Things done

  • updated the hashes

  • updated version

  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

    • sandbox = relaxed
    • sandbox = true

  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module

  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 13, 2024
@Bot-wxt1221 Bot-wxt1221 added the backport release-24.05 Backport PR automatically label Jul 14, 2024
@Bot-wxt1221
Copy link
Member

https://github.com/NixOS/nixpkgs/blob/nixos-24.05/pkgs/applications/networking/filebrowser/default.nix

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 15, 2024
@ofborg ofborg bot requested a review from nielsegberts July 15, 2024 04:34
@HritwikSinghal
Copy link
Contributor Author

Hi @iblech , can we merge this PR. seems like @nielsegberts is no longer maintaining this package.

@HritwikSinghal
Copy link
Contributor Author

@iblech can we merge this ?

@HritwikSinghal
Copy link
Contributor Author

@Aleksanaa formatted the code.

@Aleksanaa
Copy link
Member

Please remove that rec as suggested by CI

@HritwikSinghal
Copy link
Contributor Author

HritwikSinghal commented Aug 4, 2024 •
edited
Loading

Please remove that rec as suggested by CI

done 👍 , also formatted using nixfmt.

@Aleksanaa
Copy link
Member

Please squash into two commits:

maintainers: add oakenshield
filebrowser: 2.23.0 -> 2.30.0

@HritwikSinghal
Copy link
Contributor Author

Please squash into two commits:

maintainers: add oakenshield
filebrowser: 2.23.0 -> 2.30.0

Hi, did the squash and rebased on master.

@HritwikSinghal
Copy link
Contributor Author

@Aleksanaa @iblech can we merge this PR? are there any other check which need to be done?

@HritwikSinghal
Copy link
Contributor Author

@iblech @Aleksanaa kindly merge this PR. its been a week and i am afraid that before this is merged, new version of filebrowser will be released xD

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4482

@HritwikSinghal
Copy link
Contributor Author

image

@phanirithvij
Copy link
Member

other prs touching filebrowser #289750 #306615

@phanirithvij
Copy link
Member

And 2.31.0 https://github.com/filebrowser/filebrowser/releases/tag/v2.31.0

@Aleksanaa Aleksanaa changed the title filebrowser: 2.23.0 ~> 2.30.0 filebrowser: 2.23.0 -> 2.30.0 Aug 30, 2024
@HritwikSinghal
Copy link
Contributor Author

HritwikSinghal commented Aug 30, 2024 •
edited
Loading

And 2.31.0 https://github.com/filebrowser/filebrowser/releases/tag/v2.31.0

needs go 1.23 which is not there in nixpkgs unstable yet (the default is go 1.22 and 1.23 is there as "go_1_23"). Will update filebrowser in new PR

@HritwikSinghal
Copy link
Contributor Author

other prs touching filebrowser #289750 #306615

Thanks, will take help of these PR's to create a module once this PR gets merged.

@HritwikSinghal HritwikSinghal changed the title filebrowser: 2.23.0 -> 2.30.0 filebrowser: 2.23.0 -> 2.31.0 Sep 1, 2024
@HritwikSinghal
Copy link
Contributor Author

updated to v2.31.0 by using buildGo123Module instead of buildGoModule as this version requires go 1.23.

@phanirithvij
Copy link
Member

Thanks, will take help of these PR's to create a module once this PR gets merged.

There's already 4 people interested in implementing it #236165 I would suggest let's wait and see, and focus on bringing one of these 2 prs forward.
I'm just saying no need for more duplicated effort.

@phanirithvij phanirithvij added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 3, 2024
@SuperSandro2000 SuperSandro2000 merged commit cbfd470 into NixOS:master Sep 3, 2024
27 of 28 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-326932-to-release-24.05 origin/release-24.05
cd .worktree/backport-326932-to-release-24.05
git switch --create backport-326932-to-release-24.05
git cherry-pick -x 62d3695980f8e358bd7a92c754d8fb43025e6e47 37389104d7be12500a873b3d01f14340470e963c

@HritwikSinghal
Copy link
Contributor Author

Do i need to open another PR for backport? After cherry-pick, what should i do?

@SuperSandro2000
Copy link
Member

Why do we want to backport it at all? it seems like a bigger update.

@HritwikSinghal
Copy link
Contributor Author

Why do we want to backport it at all? it seems like a bigger update.

ok, i thought since the backport tags were there we need to backport it. And NixOS 24.11 is due is 3 months anyways.

@HritwikSinghal
Copy link
Contributor Author

Why do we want to backport it at all? it seems like a bigger update.

can you also review this PR. #338990

I just ran the update script in the folder itself and it updated the version. This is a security issue release so can you quickly review and merge it.

@SuperSandro2000 SuperSandro2000 removed the backport release-24.05 Backport PR automatically label Sep 3, 2024
@SuperSandro2000
Copy link
Member

This is a security issue release so can you quickly review and merge it.

please label them accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@nielsegberts nielsegberts Awaiting requested review from nielsegberts

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@iblech iblech Awaiting requested review from iblech

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@HritwikSinghal @Bot-wxt1221 @Aleksanaa @nixos-discourse @phanirithvij @SuperSandro2000 @iblech @NixOSInfra