[Backport release-24.05] brainflow: init at 5.12.1

[github-actions]

Bot-based backport to release-24.05, triggered by a label in #324462.

• Before merging, ensure that this backport is acceptable for the release.
  • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

[AndersonTorres]

:/

[infinisil]

Hey @AndersonTorres, it seems like you're frustrated from seeing this pattern too often, but I don't think it's appropriate to use a smiley face as feedback regardless. Especially when seen by newer contributors, this just makes for an uninviting atmosphere, so I'd appreciate it if you could improve on that 🙂

In this case I'd recommend something like

Using with lib; is often not recommended, see also #330035. I don't think it's necessary here.

Suggested change

	cmakeFlags = with lib; [
	cmakeFlags = [

If you don't want to type this all the time, you could also (in increasing order of difficulty):

• Use saved replies to not have to type the same response all the time
• Make a PR to document best practices regarding with in Nixpkgs, which both solidifies it as a convention for others to propagate, but also allows you to link to it
• Help creating automation to enforce such conventions automatically
• Fix the underlying problem, e.g. by pushing [RFC 0110] Add "inherit-as-list" syntax construct to the Nix language rfcs#110

[Pandapip1]

+1 from me, as the person that added the backport label in the first place