-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.brother-ql: switch to maintained fork #328273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please specify the python version explicitly in commit messages (python312Packages.foobar: ...
)
Will do in future! I was under the impression that this module is exposed under all Python 3.x versions using the same source, but if that's not the case, good to know. |
@jesskay these are all valid attributes but only commit messages with specific version, eg |
@kirillrdy Ah, gotcha! Good to know, thanks. |
Yeah it's a bug/missing feature with ofborg, I guess. |
@jesskay can you please update commit messages to use attribute |
Switches upstream to https://github.com/LunarEclipse363/brother_ql_next, and make the appropriate changes to version, format, and dependencies to follow upstream's changes. This fork incorporates the pillow patch that was previously required, so it has been removed.
Co-authored-by: éclairevoyant <[email protected]>
Co-authored-by: kirillrdy <[email protected]>
@kirillrdy That's done now. |
Description of changes
Switches upstream to https://github.com/LunarEclipse363/brother_ql_next, and makes the appropriate changes to version, format, and dependencies to follow upstream's changes.
This fork incorporates the pillow patch that was previously required, so it has been removed.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.