Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.brother-ql: switch to maintained fork #328273

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

jesskay
Copy link
Contributor

@jesskay jesskay commented Jul 18, 2024

Description of changes

Switches upstream to https://github.com/LunarEclipse363/brother_ql_next, and makes the appropriate changes to version, format, and dependencies to follow upstream's changes.

This fork incorporates the pillow patch that was previously required, so it has been removed.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 18, 2024
@ofborg ofborg bot requested a review from grahamc July 18, 2024 23:05
@jesskay jesskay marked this pull request as ready for review September 6, 2024 14:25
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please specify the python version explicitly in commit messages (python312Packages.foobar: ...)

@eclairevoyant eclairevoyant changed the title python3Packages.brother-ql: switch to maintained fork python312Packages.brother-ql: switch to maintained fork Sep 6, 2024
@jesskay
Copy link
Contributor Author

jesskay commented Sep 6, 2024

Also please specify the python version explicitly in commit messages (python312Packages.foobar: ...)

Will do in future! I was under the impression that this module is exposed under all Python 3.x versions using the same source, but if that's not the case, good to know.

@kirillrdy
Copy link
Member

@jesskay these are all valid attributes python312Packages.foobar python311Packages.foobar python3Packages.foobar

but only commit messages with specific version, eg python312Packages.foobar will trigger ofborg to build the attribute

@jesskay
Copy link
Contributor Author

jesskay commented Sep 6, 2024

@kirillrdy Ah, gotcha! Good to know, thanks.

@eclairevoyant
Copy link
Contributor

Yeah it's a bug/missing feature with ofborg, I guess.
NixOS/ofborg#577

@kirillrdy
Copy link
Member

@jesskay can you please update commit messages to use attribute python312Packages.brother-ql and/or squash commits, up to you

jesskay and others added 4 commits September 10, 2024 20:08
Switches upstream to https://github.com/LunarEclipse363/brother_ql_next, and make the appropriate changes to version, format, and dependencies to follow upstream's changes.

This fork incorporates the pillow patch that was previously required, so it has been removed.
@jesskay
Copy link
Contributor Author

jesskay commented Sep 10, 2024

@kirillrdy That's done now.

@eclairevoyant eclairevoyant merged commit e13336b into NixOS:master Sep 10, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants