less: 643 -> 661 #328985
Closed
less: 643 -> 661 #328985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inactive over a long time. NixOS#290642 Co-authored-by: Anderson Torres <[email protected]>
AndersonTorres
approved these changes
Jul 22, 2024
Ma27
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Build fails for me with
setting SOURCE_DATE_EPOCH to timestamp 1719681380 of file less-661/configure
Running phase: patchPhase
applying patch /nix/store/6ndimq5c7fjp7lk3hhgwhzlgx2fp5bw5-sec-issue-newline-path.patch
patching file filename.c
Hunk #1 succeeded at 141 with fuzz 1 (offset 8 lines).
Hunk #2 FAILED at 173.
Hunk #3 FAILED at 202.
2 out of 3 hunks FAILED -- saving rejects to file filename.c.rej
|
Oh, forgot to add the hunk with the patch removal. Anyway, #328494 was merged which I didn't notice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/gwsw/less/blob/master/NEWS
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.