-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.pprintpp: drop nose dependency #330705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s a fork, https://github.com/joaonc/pprintpp2, that contains a port to pytest. It looks like upstream was interested in merging its changes, but it never happened. Maybe we should switch to that fork, or at least source the pytest patch from 9c65ae8e89ddb71d58153b1531dc969a5948d244
. I see that you have some tests seemingly working that are skipped in that patch, although I also wonder if the parameterized tests are actually getting run correctly in this version? wolever/parameterized#167 suggests that the library they use might not work with current pytest versions.
I need to sleep soon so I’ll dig into this further another day unless you beat me to it.
I saw the fork, but wasn't sure about switching to it like this
|
You can use I think switching to the fork and giving it a |
Let's do that then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check inputs disappeared?
Seems like the fork has the same issue has me: |
That seems okay? |
Woops I think the important part is this:
|
That looks like you’re building the wrong version of the package. It’s still using nose and joaonc/pprintpp2@9c65ae8 should have removed the use of the |
Oh hum, no sure what happened |
Can you put the testing stuff back? I don’t see any reason it shouldn’t work. |
I am not sure what you meant with this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, sorry, I completely missed the nativeCheckInputs = [ pytestCheckHook ]
line last time I looked at the diff since it moved lower down in the file…
Result of nixpkgs-review pr 330705
run on aarch64-linux 1
4 packages marked as broken and skipped:
- python311Packages.ward
- python311Packages.ward.dist
- python312Packages.ward
- python312Packages.ward.dist
26 packages built:
- opshin
- opshin.dist
- python311Packages.audio-metadata
- python311Packages.audio-metadata.dist
- python311Packages.pluthon
- python311Packages.pluthon.dist
- python311Packages.pprintpp
- python311Packages.pprintpp.dist
- python311Packages.pycardano
- python311Packages.pycardano.dist
- python311Packages.tbm-utils
- python311Packages.tbm-utils.dist
- python311Packages.uplc
- python311Packages.uplc.dist
- python312Packages.audio-metadata
- python312Packages.audio-metadata.dist
- python312Packages.pluthon
- python312Packages.pluthon.dist
- python312Packages.pprintpp
- python312Packages.pprintpp.dist
- python312Packages.pycardano
- python312Packages.pycardano.dist
- python312Packages.tbm-utils
- python312Packages.tbm-utils.dist
- python312Packages.uplc
- python312Packages.uplc.dist
# https://github.com/darrenburns/ward/issues/380
broken = versionAtLeast rich.version "13.0.0"; |
An awful lot of tests are still being skipped but that’s for the upstreams to work out. |
Yeah :< |
Yes, hence “marked broken” ( |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.