-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{openlp,python3Packages.sqlalchemy-migrate,python3Packages.tempita}: drop #330855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait a week for a response.
There is an open PR for openlp #314882 |
041c5d2
to
9844aa7
Compare
I’m sorry for missing that! I’ve dropped the commit to remove the maintainers entry as it’s clearly not appropriate; I just saw that @jorsn had not made any commits since 2020 and assumed there had been no work on it. I’ve also reworded the removal message. I think that it be okay to merge this PR in the interim, with no prejudice against adding OpenLP back with the update PR. The package doesn’t build at all right now due to the insecure |
@SuperSandro2000 thank you for pointing to my PR! |
This was a major version behind and using outdated or insecure packages like sqlalchemy-migrate and Qt WebKit. It hadn’t seen any attention since it was added in 2020. If anyone wants to step up to update it to the latest version and maintain it, that would be great!
9844aa7
to
f409d1b
Compare
Sorry again about that! I checked the commit log and your most recent GitHub activity, but I should have searched the tracker too…
That sounds reasonable to me. I’ve pushed a change that hopefully sounds softer and links to the PR with a call for help; we can always adjust it later if necessary. Do you know if upstream is planning on supporting Qt 6? FOSS support for Qt 5 is ending next year, so that might be a problem down the line. |
I found no information on this and asked in the forum: https://discuss.openlp.org/d/6878-qt6-support |
Description of changes
#326513
cc @jorsn
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.