Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{openlp,python3Packages.sqlalchemy-migrate,python3Packages.tempita}: drop #330855

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jul 29, 2024

Description of changes

#326513

cc @jorsn

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient
Copy link
Member

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait a week for a response.

@SuperSandro2000
Copy link
Member

There is an open PR for openlp #314882

@emilazy emilazy changed the title {openlp,python3Packages.sqlalchemy-migrate,python3Packages.tempita}: drop; treewide: remove maintainer jorsn {openlp,python3Packages.sqlalchemy-migrate,python3Packages.tempita}: drop Jul 31, 2024
@github-actions github-actions bot removed 6.topic: vim 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jul 31, 2024
@emilazy
Copy link
Member Author

emilazy commented Jul 31, 2024

I’m sorry for missing that! I’ve dropped the commit to remove the maintainers entry as it’s clearly not appropriate; I just saw that @jorsn had not made any commits since 2020 and assumed there had been no work on it. I’ve also reworded the removal message.

I think that it be okay to merge this PR in the interim, with no prejudice against adding OpenLP back with the update PR. The package doesn’t build at all right now due to the insecure qtwebkit dependency and incompatibilities with Python 3.12 and SQLAlchemy 2, and as it seems like the maintainer doesn’t use the package and nobody else has stepped up to help with it, I’m unsure if there is enough interest to get the update over the finish line and sustainably maintain this package.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 31, 2024
@jorsn
Copy link
Member

jorsn commented Aug 2, 2024

@SuperSandro2000 thank you for pointing to my PR!
@emilazy Alright, I support that in principle, and thank you for not removing me as a maintainer :) However, in this PR, it is not entirely removed, but rather replaced by an error message stating it is removed. This sounds like a permanent thing, and I propose to add to the error message that a package for OpenLP-3 is being worked on – maybe even with the PR number (#314882). I think we can get the update for openlp, because Cyber_Raven offered help with maintenance in the forum. I was only too busy in the last two weeks to give starting instructions and update my PR.

This was a major version behind and using outdated or insecure packages
like sqlalchemy-migrate and Qt WebKit. It hadn’t seen any attention
since it was added in 2020. If anyone wants to step up to update it
to the latest version and maintain it, that would be great!
@emilazy
Copy link
Member Author

emilazy commented Aug 3, 2024

thank you for not removing me as a maintainer :)

Sorry again about that! I checked the commit log and your most recent GitHub activity, but I should have searched the tracker too…

However, in this PR, it is not entirely removed, but rather replaced by an error message stating it is removed. This sounds like a permanent thing, and I propose to add to the error message that a package for OpenLP-3 is being worked on – maybe even with the PR number (#314882). I think we can get the update for openlp, because Cyber_Raven offered help with maintenance in the forum. I was only too busy in the last two weeks to give starting instructions and update my PR.

That sounds reasonable to me. I’ve pushed a change that hopefully sounds softer and links to the PR with a call for help; we can always adjust it later if necessary.

Do you know if upstream is planning on supporting Qt 6? FOSS support for Qt 5 is ending next year, so that might be a problem down the line.

@emilazy emilazy merged commit 2c79576 into NixOS:master Aug 9, 2024
22 checks passed
@emilazy emilazy mentioned this pull request Aug 9, 2024
21 tasks
@jorsn
Copy link
Member

jorsn commented Aug 12, 2024

Do you know if upstream is planning on supporting Qt 6? FOSS support for Qt 5 is ending next year, so that might be a problem down the line.

I found no information on this and asked in the forum: https://discuss.openlp.org/d/6878-qt6-support

@emilazy emilazy deleted the push-mrtsqsqnwxry branch August 26, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
Development

Successfully merging this pull request may close these issues.

7 participants