Drop end‐of‐life JDK and JavaFX versions 16 to 20 #331514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not “drop”; these files are literally not referenced anywhere in the tree, as far as I can tell.
These have all been end‐of‐life for more than 10 months.
Seems to start up fine for me with the default JRE, and the package couldn’t be easily used before this anyway as version 20 has reached end of life. It does complain about what a big mistake we’re making by not passing Shenandoah GC flags to the JVM on start‐up, but I doubt that has anything to do with the JRE bump, and it lets you click through.
emilazy
force-pushed
the
push-yyzkwpzzzult
branch
from
fdf274b
to
7047710
Compare
|
@Aleksanaa @inclyc Any way to tell |
|
See #331085. You just comment it out or ignore it for now, it's fine |
These have all been end‐of‐life for more than 10 months.
emilazy
force-pushed
the
push-yyzkwpzzzult
branch
from
7047710
to
4f93a66
Compare
|
Commenting it out works for me; pushed. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a prerequisite to my FFmpeg 4 work, but also just a good idea in general. Per https://endoflife.date/oracle-jdk and https://endoflife.date/amazon-corretto, these versions have been unsupported for between 10½ and 22½ months and it’ll be 3 months more by the time the next NixOS release comes out. They were all marked as insecure anyway, and some weren’t even exposed at the top level, so nobody should miss them.
I’ve also removed the end‐of‐life Temurin and Semeru packages for these versions, per https://endoflife.date/eclipse-temurin and https://endoflife.date/ibm-semeru-runtime. These are less of a maintenance burden, though, and don’t block my FFmpeg work, so if people really want to keep them around despite them being marked as insecure I can drop that commit.
Closes: #170825
Result of
nixpkgs-reviewrun on x86_64-linux 11 package built:
Result of
nixpkgs-reviewrun on aarch64-linux 11 package built:
Result of
nixpkgs-reviewrun on aarch64-darwin 11 package built:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.