mtk_uartboot: init at 0.1.1 #333260
mtk_uartboot: init at 0.1.1 #333260
Conversation
ofborg
bot
added
8.has: package (new)
MatthewCroughan
force-pushed
the
mc/mtk_uartboot
branch
from
684d972 to
8342438
Compare
|
Can you reformat the file with PS: great talks on yt :D |
|
@Sigmanificient Maybe you can merge it and then do that? In my view, if things like this are going to be requested from contributors, it should be an automatic treewide commit, the same as other mass-changes. I have not really been bothered by code style comments in PRs before, did something happen to ratify this and make it mandatory in PRs? |
|
I don't have the rights to merge / edits sadly, I mean still at the very beginning of my nixpkgs journey 😅 It's been ~2 weeks |
|
Ouch, I hate it. diff --git a/pkgs/by-name/mt/mtk_uartboot/package.nix b/pkgs/by-name/mt/mtk_uartboot/package.nix
index a9c0233c9556..34549bb688fa 100644
--- a/pkgs/by-name/mt/mtk_uartboot/package.nix
+++ b/pkgs/by-name/mt/mtk_uartboot/package.nix
@@ -1,8 +1,9 @@
-{ lib
-, rustPlatform
-, fetchFromGitHub
-, stdenv
-, darwin
+{
+ lib,
+ rustPlatform,
+ fetchFromGitHub,
+ stdenv,
+ darwin,
}:Now I can't use visual mode in vim to modify or remove multiple lines of I dislike this change, oh well. |
Co-authored-by: Yohann Boniface <[email protected]>
MatthewCroughan
force-pushed
the
mc/mtk_uartboot
branch
from
8342438 to
8b25590
Compare
|
I'm sorry to hear that, may you leave your feedback in Satisfaction survey from the new RFC 166 formatting? |
|
|
||
| cargoHash = "sha256-At+HkvHcn6kAkSxBqFlaxUTZ7Xuy2lARMFQ2i6uybSk="; | ||
|
|
||
| buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.IOKit ]; |
There was a problem hiding this comment.
| buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.IOKit ]; | |
| buildInputs = lib.optionals stdenv.hostPlatform.isDarwin [ darwin.apple_sdk.frameworks.IOKit ]; |
| buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.IOKit ]; | ||
|
|
||
| meta = with lib; { | ||
| description = "third-party tool to load and execute binaries over UART for Mediatek SoCs"; |
There was a problem hiding this comment.
| description = "third-party tool to load and execute binaries over UART for Mediatek SoCs"; | |
| description = "Third-party tool to load and execute binaries over UART for Mediatek SoCs"; |
| src = fetchFromGitHub { | ||
| owner = "981213"; | ||
| repo = "mtk_uartboot"; | ||
| rev = "refs/v${version}"; |
There was a problem hiding this comment.
| rev = "refs/v${version}"; | |
| rev = "refs/tags/v${version}"; |
| cargoHash = "sha256-At+HkvHcn6kAkSxBqFlaxUTZ7Xuy2lARMFQ2i6uybSk="; | ||
|
|
||
| buildInputs = lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.IOKit ]; | ||
|
|
There was a problem hiding this comment.
| doCheck = false; # no tests |
Description of changes
Adds https://github.com/981213/mtk_uartboot to nixpkgs
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.