-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.textual: 0.72.0 -> 0.79.0 #333360
Conversation
3398e10
to
a0b66d0
Compare
47ebd83
to
a9853d5
Compare
the build failure strikes me as a concurrency issue, consider removing pytest-xdist |
Correct. I checked with upstream and they suggest adding the flag I put in with the last edit to force group execution. Some of their tests rely on state from previous tests in the same group. |
but it still breaks |
Where? I added the group argument and it now passes, because it runs all the related tests from the group in a single thread. The run you linked appears to be from before I added the extra flag, from what I can tell. |
That's from the previous commit where I hadn't added the options, from what I can tell. |
ca7bb73
to
e660ec2
Compare
Any chance this gets merged soon? I need it for a downstream dependency. |
Result of 4 packages failed to build:
45 packages built:
|
e660ec2
to
16f2177
Compare
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.