treewide/nixos: remove with lib; part 3
#335623
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-3
branch
from
b00f6d9
to
6412e0b
Compare
Stunkymonkey
changed the title
with lib; part 3
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-3
branch
11 times, most recently
from
19b42fc
to
8ac0216
Compare
ofborg
bot
added
10.rebuild-darwin: 0
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-3
branch
3 times, most recently
from
4341673
to
3250550
Compare
ofborg
bot
added
the
2.status: merge conflict
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-3
branch
from
3250550
to
c022b7b
Compare
ofborg
bot
removed
the
2.status: merge conflict
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-3
branch
4 times, most recently
from
1b2289a
to
6b8fd89
Compare
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-3
branch
from
6b8fd89
to
be9cf40
Compare
Ma27
requested changes
Sep 16, 2024
There was a problem hiding this comment.
AFAIK this is done by some automation: #335603 (comment)
Given that this has always caused a notable fallout that maintainers had to fix afterwards, did you fix the script or are we expecting a different result this time?
yes exactly the same script. Automation is not changed. I was expecting 2 reviewers is enough to detect the problems. Definitely not a fault of the reviewers! |
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #208242
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.